Amolith
/
codies
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reject duplicate client IDs

This commit is contained in:
zikaeroh 2020-06-14 12:23:33 -07:00
parent d6517bf0d3
commit bee5fe4af3
1 changed files with 28 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/server/server.go
View File

@ -245,7 +245,15 @@ func (r *Room) HandleConn(ctx context.Context, playerID uuid.UUID, nickname stri
g, ctx := errgroup.WithContext(ctx) g, ctx := errgroup.WithContext(ctx)
setup := func() (success bool) {
r.mu.Lock() r.mu.Lock()
defer r.mu.Unlock()
if _, ok := r.players[playerID]; ok {
ctxlog.Warn(ctx, "client with this ID already exists")
return false
}
r.players[playerID] = func(s protocol.ServerNote) { r.players[playerID] = func(s protocol.ServerNote) {
if ctx.Err() != nil { if ctx.Err() != nil {
return return
@ -264,7 +272,12 @@ func (r *Room) HandleConn(ctx context.Context, playerID uuid.UUID, nickname stri
} }
r.room.AddPlayer(playerID, nickname) r.room.AddPlayer(playerID, nickname)
r.sendAll() r.sendAll()
r.mu.Unlock() return true
}
if !setup() {
return
}
defer func() { defer func() {
r.mu.Lock() r.mu.Lock()