Browse Source

Moved timeout control from the tests to the CI pipeline

How fast a tests is executed on a shared CI pipeline is not predictable as the build might be throttled because other builds are running.
Therefore adding extremely short timeouts inside the tests - where they can't be changed - is a bad idea.
Removed them for now.
pull/7670/head
litetex 4 months ago
parent
commit
a6515d5450
  1. 1
      .github/workflows/ci.yml
  2. 3
      app/src/androidTest/java/org/schabi/newpipe/local/history/HistoryRecordManagerTest.kt
  3. 3
      app/src/androidTest/java/org/schabi/newpipe/local/playlist/LocalPlaylistManagerTest.kt

1
.github/workflows/ci.yml

@ -52,6 +52,7 @@ jobs:
test-android:
# macos has hardware acceleration. See android-emulator-runner action
runs-on: macos-latest
timeout-minutes: 20
strategy:
matrix:
# api-level 19 is min sdk, but throws errors related to desugaring

3
app/src/androidTest/java/org/schabi/newpipe/local/history/HistoryRecordManagerTest.kt

@ -25,9 +25,6 @@ class HistoryRecordManagerTest {
@get:Rule
val trampolineScheduler = TrampolineSchedulerRule()
@get:Rule
val timeout = Timeout(1, TimeUnit.SECONDS)
@Before
fun setup() {
database = TestDatabase.createReplacingNewPipeDatabase()

3
app/src/androidTest/java/org/schabi/newpipe/local/playlist/LocalPlaylistManagerTest.kt

@ -20,9 +20,6 @@ class LocalPlaylistManagerTest {
@get:Rule
val trampolineScheduler = TrampolineSchedulerRule()
@get:Rule
val timeout = Timeout(1, TimeUnit.SECONDS)
@Before
fun setup() {
database = TestDatabase.createReplacingNewPipeDatabase()

Loading…
Cancel
Save