From d9188faa3c15caf57d953ab757a88f51d276de8e Mon Sep 17 00:00:00 2001 From: Russ Magee Date: Fri, 19 Dec 2025 23:07:03 -0800 Subject: [PATCH] Comment about observed issue with MSYS2 paths outside of install tree --- xs/xs.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xs/xs.go b/xs/xs.go index 788c456..e882a20 100755 --- a/xs/xs.go +++ b/xs/xs.go @@ -626,6 +626,12 @@ func parseNonSwitchArgs(a []string) (user, host, path string, isDest bool, other // Whether fancyArg is src or dst file depends on flag.Args() index; // fancyArg as last flag.Args() element denotes dstFile // fancyArg as not-last flag.Args() element denotes srcFile + + /* rlm:2025-12-10 This breaks if srcPath is outside of MSYS2 tree, as srcPath + appears to silently be converted to an absolute winpath eg., + /c/users/RM/... -> C:/users/RM/... + and the colon (:) in this breaks the logic below. + */ var fancyUser, fancyHost, fancyPath string for i, arg := range a { if strings.Contains(arg, ":") || strings.Contains(arg, "@") {