From 38e688fcd9f51eb7bc0783cb9ab813ca28f7175d Mon Sep 17 00:00:00 2001 From: Pat Hawks Date: Tue, 1 Mar 2016 21:14:18 -0800 Subject: [PATCH 1/3] Check for existance of seo_page_title before outputting --- lib/template.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/template.html b/lib/template.html index 4b87b8e..ab09fc9 100644 --- a/lib/template.html +++ b/lib/template.html @@ -88,7 +88,7 @@ {{ seo_title }} {% endif %} -{% if seo_title %} +{% if seo_page_title %} {% endif %} From 2c808aced6eaff3867c7a39514074a4ab38c4697 Mon Sep 17 00:00:00 2001 From: Pat Hawks Date: Tue, 1 Mar 2016 21:14:32 -0800 Subject: [PATCH 2/3] Do not repeat Open Graph tags for Twitter --- lib/template.html | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/template.html b/lib/template.html index ab09fc9..ba29151 100644 --- a/lib/template.html +++ b/lib/template.html @@ -126,12 +126,6 @@ {% if site.twitter %} - - - - {% if page.image %} - - {% endif %} {% if seo_author_twitter %} From 55ead7fcb85eb30452ffe638d6dc3fb0944f1075 Mon Sep 17 00:00:00 2001 From: Pat Hawks Date: Tue, 1 Mar 2016 21:20:31 -0800 Subject: [PATCH 3/3] Remove obsolete twitter:image test --- spec/jekyll_seo_tag_spec.rb | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/spec/jekyll_seo_tag_spec.rb b/spec/jekyll_seo_tag_spec.rb index 4fa5a1d..ca664ff 100644 --- a/spec/jekyll_seo_tag_spec.rb +++ b/spec/jekyll_seo_tag_spec.rb @@ -266,16 +266,6 @@ EOS expect(output).to match(expected) end end - - context 'with page.image' do - let(:site) { make_site('twitter' => site_twitter, 'url' => 'http://example.invalid') } - let(:page) { make_page('image' => '/img/foo.png') } - - it 'outputs the image' do - expected = %r{} - expect(output).to match(expected) - end - end end end