Do not cache the drop payload for SeoTag (#306)

Merge pull request 306
This commit is contained in:
Ashwin Maroli 2019-03-16 14:00:11 +05:30 committed by jekyllbot
parent ad3f7e3f48
commit 2f80d62208
1 changed files with 14 additions and 1 deletions

View File

@ -56,7 +56,20 @@ module Jekyll
end
def drop
@drop ||= Jekyll::SeoTag::Drop.new(@text, @context)
# TODO: Modify following comment once Jekyll 4.0 ships.
# ------------------------------------------------------------------------------------------
# Jekyll 4.0 is probably going to cache parsed Liquid Templates which is going to break the
# rendered output from this tag since there's going to be just a single instance of this
# class per {% seo %} in a template, (especially when the tag is used as part of an include).
# -------------------------------------------------------------------------------------------
#
# FIXME: Switch to using `if Gem::Version.new(Jekyll::VERSION) >= Gem::Version.new("4.0.0")`
# once Jekyll 4.0 ships.
if context.registers[:site].liquid_renderer.respond_to?(:cache)
Jekyll::SeoTag::Drop.new(@text, @context)
else
@drop ||= Jekyll::SeoTag::Drop.new(@text, @context)
end
end
def info