diff --git a/History.markdown b/History.markdown index fe18398..edfe7d8 100644 --- a/History.markdown +++ b/History.markdown @@ -1,6 +1,7 @@ ## HEAD * Use canonical_url specified in page if present #211 +* Fix for image.path causing an invalid url error #228 ## 2.2.3 diff --git a/lib/jekyll-seo-tag/drop.rb b/lib/jekyll-seo-tag/drop.rb index 632c2d4..1973c65 100644 --- a/lib/jekyll-seo-tag/drop.rb +++ b/lib/jekyll-seo-tag/drop.rb @@ -168,7 +168,8 @@ module Jekyll image["path"] ||= image["facebook"] || image["twitter"] return @image = nil unless image["path"] - unless absolute_url? image["path"] + # absolute_url? will return nil for an invalid URL + if absolute_url?(image["path"]) == false image["path"] = filters.absolute_url image["path"] end diff --git a/spec/jekyll_seo_tag/drop_spec.rb b/spec/jekyll_seo_tag/drop_spec.rb index a47ad67..80fb871 100644 --- a/spec/jekyll_seo_tag/drop_spec.rb +++ b/spec/jekyll_seo_tag/drop_spec.rb @@ -572,7 +572,7 @@ RSpec.describe Jekyll::SeoTag::Drop do let(:image) { ":" } it "returns nil" do - expect(subject.image["path"]).to eql("/:") + expect(subject.image["path"]).to eql(":") end end