diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..75291c8 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,103 @@ +name: Continuous Integration + +on: + push: + branches: + - master + pull_request: + branches: + - master + +jobs: + j4: + if: "!contains(github.event.commits[0].message, '[ci skip]')" + name: "Jekyll ${{ matrix.jekyll_version }} (Ruby ${{ matrix.ruby_version }})" + runs-on: 'ubuntu-latest' + env: + JEKYLL_VERSION: ${{ matrix.jekyll_version }} + strategy: + fail-fast: false + matrix: + ruby_version: + - 2.5 + - 2.7 + - 3.0 + jekyll_version: + - "~> 4.0" + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 5 + - name: "Set up Ruby ${{ matrix.ruby_version }}" + uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby_version }} + bundler-cache: true + - name: Execute tests + run: bundle exec rspec + j3: + if: "!contains(github.event.commits[0].message, '[ci skip]')" + name: "Jekyll ${{ matrix.jekyll_version }} (Ruby ${{ matrix.ruby_version }})" + runs-on: 'ubuntu-latest' + env: + JEKYLL_VERSION: ${{ matrix.jekyll_version }} + strategy: + fail-fast: false + matrix: + ruby_version: + - 2.5 + jekyll_version: + - "~> 3.9" + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 5 + - name: "Set up Ruby ${{ matrix.ruby_version }}" + uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby_version }} + bundler-cache: true + - name: Execute tests + run: bundle exec rspec + + style_check: + if: "!contains(github.event.commits[0].message, '[ci skip]')" + name: "Code Style Check (Ruby ${{ matrix.ruby_version }})" + runs-on: 'ubuntu-latest' + strategy: + fail-fast: false + matrix: + ruby_version: + - 2.5 + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 5 + - name: "Set up Ruby ${{ matrix.ruby_version }}" + uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby_version }} + bundler-cache: true + - name: Check Style Offenses + run: bundle exec rubocop -S -D + + gem_build: + if: "!contains(github.event.commits[0].message, '[ci skip]')" + name: "Test Gem build (Ruby ${{ matrix.ruby_version }})" + runs-on: 'ubuntu-latest' + strategy: + fail-fast: false + matrix: + ruby_version: + - 2.5 + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 5 + - name: "Set up Ruby ${{ matrix.ruby_version }}" + uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby_version }} + bundler-cache: true + - name: Test Gem build + run: bundle exec gem build jekyll-seo-tag.gemspec diff --git a/.github/workflows/scripts/memprof b/.github/workflows/scripts/memprof new file mode 100644 index 0000000..2f06786 --- /dev/null +++ b/.github/workflows/scripts/memprof @@ -0,0 +1,4 @@ +#!/usr/bin/env bash + +bundle exec ruby jekyll-seo-tag/.github/workflows/scripts/memprof.rb sandbox +exit 0 diff --git a/.github/workflows/scripts/memprof.rb b/.github/workflows/scripts/memprof.rb new file mode 100644 index 0000000..45143d8 --- /dev/null +++ b/.github/workflows/scripts/memprof.rb @@ -0,0 +1,14 @@ +# frozen_string_literal: true + +require 'jekyll' +require 'memory_profiler' + +MemoryProfiler.report(allow_files: 'lib/jekyll-seo-tag') do + Jekyll::PluginManager.require_from_bundler + Jekyll::Commands::Build.process({ + "source" => File.expand_path(ARGV[0]), + "destination" => File.expand_path("#{ARGV[0]}/_site"), + "disable_disk_cache" => true, + }) + puts '' +end.pretty_print(scale_bytes: true, normalize_paths: true) diff --git a/.github/workflows/third-party.yml b/.github/workflows/third-party.yml new file mode 100644 index 0000000..aa773f3 --- /dev/null +++ b/.github/workflows/third-party.yml @@ -0,0 +1,62 @@ +name: Third-Party Repository Profiling + +on: + push: + branches: + - master + pull_request: + branches: + - master +jobs: + build_n_profile: + name: "Third-Party Repo Profile with Jekyll ${{ matrix.jekyll_version }} (Ruby ${{ matrix.ruby_version }})" + runs-on: "ubuntu-latest" + strategy: + fail-fast: false + matrix: + ruby_version: + - 2.7 + jekyll_version: + - "~> 4.0" + - "~> 3.9" + env: + BUNDLE_GEMFILE: "sandbox/Gemfile" + BUNDLE_PATH: "vendor/bundle" + BUNDLE_JOBS: 4 + BUNDLE_RETRY: 3 + JEKYLL_VERSION: ${{ matrix.jekyll_version }} + steps: + - name: Checkout Jekyll SEO Tag + uses: actions/checkout@v2 + with: + fetch-depth: 5 + path: jekyll-seo-tag + - name: Checkout Third-Party Repository (WITHOUT SEO Tag) + uses: actions/checkout@v2 + with: + repository: ashmaroli/tomjoht.github.io + ref: "no-seo-tag" + path: alpha-sandbox + - name: Checkout Same Third-Party Repository (WITH SEO Tag) + uses: actions/checkout@v2 + with: + repository: ashmaroli/tomjoht.github.io + ref: "seo-tag" + path: sandbox + - name: "Set up Ruby ${{ matrix.ruby_version }}" + uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby_version }} + bundler-cache: true + - name: Run Jekyll Build (WITHOUT SEO Tag) 3 times + run: | + bundle exec jekyll build -s alpha-sandbox -d alpha-sandbox/_site --trace + bundle exec jekyll build -s alpha-sandbox -d alpha-sandbox/_site --trace + bundle exec jekyll build -s alpha-sandbox -d alpha-sandbox/_site --trace + - name: Run Jekyll Build (WITH SEO Tag) 3 times + run: | + bundle exec jekyll build -s sandbox -d sandbox/_site --trace + bundle exec jekyll build -s sandbox -d sandbox/_site --trace + bundle exec jekyll build -s sandbox -d sandbox/_site --trace + - name: Memory Analysis of Jekyll Build (WITH SEO Tag) + run: bash jekyll-seo-tag/.github/workflows/scripts/memprof diff --git a/.rubocop.yml b/.rubocop.yml index 8ed2cfa..6688e6d 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -5,15 +5,38 @@ inherit_gem: rubocop-jekyll: .rubocop.yml AllCops: - TargetRubyVersion: 2.3 + TargetRubyVersion: 2.5 + SuggestExtensions: false Exclude: - vendor/**/* +Layout/LineEndStringConcatenationIndentation: + Enabled: true Layout/LineLength: Exclude: - spec/**/* - jekyll-seo-tag.gemspec -Layout/BlockLength: +Lint/EmptyInPattern: + Enabled: false + +Metrics/BlockLength: Exclude: - spec/**/* + +Naming/InclusiveLanguage: + Enabled: false + +Performance/MapCompact: + Enabled: true +Performance/RedundantEqualityComparisonBlock: + Enabled: true +Performance/RedundantSplitRegexpArgument: + Enabled: true + +Style/InPatternThen: + Enabled: false +Style/MultilineInPatternThen: + Enabled: false +Style/QuotedSymbols: + Enabled: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cb469c1..59fd59b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,46 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude` -# on 2020-03-20 11:41:46 +0100 using RuboCop version 0.80.1. +# on 2021-09-17 06:40:32 UTC using RuboCop version 1.18.4. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 1 +# Configuration parameters: AllowComments. +Lint/EmptyClass: + Exclude: + - 'lib/jekyll-seo-tag/version.rb' + +# Offense count: 3 +Lint/NoReturnInBeginEndBlocks: + Exclude: + - 'lib/jekyll-seo-tag/author_drop.rb' + - 'lib/jekyll-seo-tag/drop.rb' + # Offense count: 1 # Cop supports --auto-correct. Lint/ToJSON: Exclude: - 'lib/jekyll-seo-tag/json_ld_drop.rb' + +# Offense count: 1 +# Configuration parameters: IgnoredMethods, Max. +Metrics/PerceivedComplexity: + Exclude: + - 'lib/jekyll-seo-tag/drop.rb' + +# Offense count: 1 +# Configuration parameters: MinSize. +Performance/CollectionLiteralInLoop: + Exclude: + - 'spec/jekyll_seo_tag/author_drop_spec.rb' + +# Offense count: 9 +# Cop supports --auto-correct. +Style/RedundantBegin: + Exclude: + - 'lib/jekyll-seo-tag.rb' + - 'lib/jekyll-seo-tag/author_drop.rb' + - 'lib/jekyll-seo-tag/drop.rb' + - 'lib/jekyll-seo-tag/image_drop.rb' diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 3575f92..0000000 --- a/.travis.yml +++ /dev/null @@ -1,18 +0,0 @@ -language: ruby -cache: bundler -rvm: - - 2.5 - - 2.7 - -before_install: - - gem update --system - - gem install bundler - -script: script/cibuild - -env: - global: - - NOKOGIRI_USE_SYSTEM_LIBRARIES=true - matrix: - - JEKYLL_VERSION="~> 3.8" - - JEKYLL_VERSION="~> 4.0" diff --git a/Gemfile b/Gemfile index a1ebfdb..40f83de 100644 --- a/Gemfile +++ b/Gemfile @@ -5,3 +5,4 @@ source "https://rubygems.org" gemspec gem "jekyll", ENV["JEKYLL_VERSION"] if ENV["JEKYLL_VERSION"] +gem "kramdown-parser-gfm" if ENV["JEKYLL_VERSION"] == "~> 3.9" diff --git a/History.markdown b/History.markdown index fdb8d0b..5f13ab2 100644 --- a/History.markdown +++ b/History.markdown @@ -1,33 +1,59 @@ ## HEAD -### Documentation - - * HTTPS links to schema.org (#350) - * use example.com for example URL (#351) - * remove Google+ from example snippet (#358) - * HTTPS link to https://ogp.me/ (#359) - * Rename Google webmaster tools to Google Search Console (#403) - * Improve documentation on plugin usage (#399) - * Structured Data Testing Tool is deprecated (#409) - ### Minor Enhancements - * Adding possibility to change pagination message by config file (#324) - * Make Twitter Summary Card without having Twitter account (#284) - * Ensure a single leading `@` for twitter usernames (#367) - * Prefer site.tagline to site.description for page title (#356) - * chore(ci): bump Ruby versions (#385) + * Allow to set type for author (#427) + * Allow setting `author.url` (#453) ### Development Fixes - * Memoize #author_hash in SeoTag::AuthorDrop (#342) - * chore(ci): test Jekyll v4.0 (#372) - * Fix locale specs that use the fallback locale (#360) - * style: align with latest jekyll-rubocop (#382) + * Fix typo in source code comment (#449) + * Set up Continuous Integration via GH Actions (#450) + * Bump RuboCop to v1.18.x (#452) + +## 2.7.1 / 2020-10-18 + +### Development Fixes + + * refactor: mutate site payload instead of duplicating it (#419) + +## 2.7.0 / 2020-10-18 + +### Minor Enhancements + + * Change pagination message with `seo_paginator_message` option (#324) + * Make Twitter Summary Card without having Twitter account (#284) + * Prefer site.tagline to site.description for page title (#356) + * Render og:locale meta only when defined explicitly (#388) ### Bug Fixes - * Reduce allocations of instance-agnostic objects (#376) + * Ensure a single leading `@` for twitter usernames (#367) + +### Development Fixes + + * chore(deps): require Ruby > 2.4.0 EOL + * test: fix locale specs that use the fallback locale (#360) + * refactor: Replace read-only empty hash with private constant (#418) + * refactor: Mutate hash literals instead of duplicating them (#417) + * refactor: Reduce allocations of instance-agnostic objects (#376) + * refactor: Memoize #author_hash in SeoTag::AuthorDrop (#342) + * refactor: simplify conditional in SeoTag::Drop#date_modified (#343) + * chore(ci): profile seo-tag plugin on a third-party repository (#414) + * chore(ci): Jekyll v4.0 (#372) + * chore(ci): test against current stable Ruby 2.5 and 2.7 (#385) + * style: align with latest jekyll-rubocop (#382) + * fix: Travis builds for Jekyll 3.x (#415) + +### Documentation + + * Structured Data Testing Tool is deprecated (#409) + * Rename Google webmaster tools to Google Search Console (#403) + * Improve documentation on plugin usage (#399) + * remove Google+ from example snippet (#358) + * HTTPS link to https://ogp.me/ (#359) + * HTTPS links to schema.org (#350) + * use example.com for example URL (#351) ## 2.6.1 / 2019-05-17 diff --git a/docs/advanced-usage.md b/docs/advanced-usage.md index a0d0a57..e534abd 100644 --- a/docs/advanced-usage.md +++ b/docs/advanced-usage.md @@ -68,6 +68,18 @@ There are several ways to convey this author-specific information. Author inform author: benbalter ``` +#### Setting author url + +Starting from August 6, 2021 [Google recommends](https://developers.google.com/search/updates) to set the `author.url` property. This property helps Google to disambiguate the correct author of the article. + +You can set it the same way as the other author properties. For example, you can put it in an `author` object, in the site's `_config.yml`, e.g.: + + ```yml + author: + name: My Name + url: https://example.com/ + ``` + ### Customizing JSON-LD output The following options can be set for any particular page. While the default options are meant to serve most users in the most common circumstances, there may be situations where more precise control is necessary. diff --git a/docs/usage.md b/docs/usage.md index 78fcf07..489c233 100644 --- a/docs/usage.md +++ b/docs/usage.md @@ -66,7 +66,8 @@ The following properties are available: yandex: 1234 baidu: 1234 ``` -* `lang` - The locale these tags are marked up in. Of the format `language_TERRITORY`. Default is `en_US`. +* `locale` - The locale these tags are marked up in. Of the format `language_TERRITORY`. Default is `en_US`. Takes priority +over existing config key `lang`. The SEO tag will respect the following YAML front matter if included in a post, page, or document: @@ -74,6 +75,6 @@ The SEO tag will respect the following YAML front matter if included in a post, * `description` - A short description of the page's content * `image` - URL to an image associated with the post, page, or document (e.g., `/assets/page-pic.jpg`) * `author` - Page-, post-, or document-specific author information (see [Advanced usage](advanced-usage.md#author-information)) -* `lang` - Page-, post-, or document-specific language information +* `locale` - Page-, post-, or document-specific locale information. Takes priority over existing front matter attribute `lang`. *Note:* Front matter defaults can be used for any of the above values as described in advanced usage with an image example. diff --git a/jekyll-seo-tag.gemspec b/jekyll-seo-tag.gemspec index 97a0232..487444b 100644 --- a/jekyll-seo-tag.gemspec +++ b/jekyll-seo-tag.gemspec @@ -19,16 +19,16 @@ Gem::Specification.new do |spec| raise "RubyGems 2.0 or newer is required to protect against public gem pushes." end - spec.required_ruby_version = ">= 2.3.0" + spec.required_ruby_version = ">= 2.5.0" spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r!^(test|spec|features)/!) } spec.bindir = "exe" spec.executables = spec.files.grep(%r!^exe/!) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "jekyll", ">= 3.3", "< 5.0" + spec.add_dependency "jekyll", ">= 3.8", "< 5.0" spec.add_development_dependency "bundler", ">= 1.15" spec.add_development_dependency "html-proofer", "~> 3.7" spec.add_development_dependency "rspec", "~> 3.5" - spec.add_development_dependency "rubocop-jekyll", "~> 0.11" + spec.add_development_dependency "rubocop-jekyll", "~> 0.12.0" end diff --git a/lib/jekyll-seo-tag.rb b/lib/jekyll-seo-tag.rb index 589fd13..2edafd7 100644 --- a/lib/jekyll-seo-tag.rb +++ b/lib/jekyll-seo-tag.rb @@ -47,12 +47,11 @@ module Jekyll def payload # site_payload is an instance of UnifiedPayloadDrop. See https://git.io/v5ajm - Jekyll::Utils.deep_merge_hashes( - context.registers[:site].site_payload, - "page" => context.registers[:page], - "paginator" => context["paginator"], - "seo_tag" => drop - ) + context.registers[:site].site_payload.tap do |site_payload| + site_payload["page"] = context.registers[:page] + site_payload["paginator"] = context["paginator"] + site_payload["seo_tag"] = drop + end end def drop diff --git a/lib/jekyll-seo-tag/author_drop.rb b/lib/jekyll-seo-tag/author_drop.rb index b55cff0..9d534cb 100644 --- a/lib/jekyll-seo-tag/author_drop.rb +++ b/lib/jekyll-seo-tag/author_drop.rb @@ -41,8 +41,7 @@ module Jekyll private - attr_reader :page - attr_reader :site + attr_reader :site, :page # Finds the page author in the page.author, page.authors, or site.author # @@ -75,10 +74,11 @@ module Jekyll # or an empty hash, if the author cannot be resolved def author_hash @author_hash ||= begin - if resolved_author.is_a? Hash + case resolved_author + when Hash resolved_author - elsif resolved_author.is_a? String - { "name" => resolved_author }.merge(site_data_hash) + when String + { "name" => resolved_author }.merge!(site_data_hash) else {} end diff --git a/lib/jekyll-seo-tag/drop.rb b/lib/jekyll-seo-tag/drop.rb index cb806d6..157babd 100644 --- a/lib/jekyll-seo-tag/drop.rb +++ b/lib/jekyll-seo-tag/drop.rb @@ -11,8 +11,11 @@ module Jekyll ].freeze HOMEPAGE_OR_ABOUT_REGEX = %r!^/(about/)?(index.html?)?$!.freeze + EMPTY_READ_ONLY_HASH = {}.freeze + private_constant :EMPTY_READ_ONLY_HASH + def initialize(text, context) - @obj = {} + @obj = EMPTY_READ_ONLY_HASH @mutations = {} @text = text @context = context @@ -109,13 +112,7 @@ module Jekyll def date_modified @date_modified ||= begin - date = if page_seo["date_modified"] - page_seo["date_modified"] - elsif page["last_modified_at"] - page["last_modified_at"].to_liquid - else - page["date"] - end + date = page_seo["date_modified"] || page["last_modified_at"].to_liquid || page["date"] filters.date_to_xmlschema(date) if date end end @@ -164,6 +161,10 @@ module Jekyll @page_lang ||= page["lang"] || site["lang"] || "en_US" end + def page_locale + @page_locale ||= (page["locale"] || site["locale"] || page_lang).tr("-", "_") + end + def canonical_url @canonical_url ||= begin if page["canonical_url"].to_s.empty? @@ -238,7 +239,7 @@ module Jekyll if hash[key].is_a?(Hash) hash[key] else - {} + EMPTY_READ_ONLY_HASH end end end diff --git a/lib/jekyll-seo-tag/image_drop.rb b/lib/jekyll-seo-tag/image_drop.rb index 32148ed..43367a4 100644 --- a/lib/jekyll-seo-tag/image_drop.rb +++ b/lib/jekyll-seo-tag/image_drop.rb @@ -34,18 +34,22 @@ module Jekyll private - attr_accessor :page - attr_accessor :context + attr_accessor :page, :context # The normalized image hash with a `path` key (which may be nil) def image_hash - @image_hash ||= if page["image"].is_a?(Hash) - { "path" => nil }.merge(page["image"]) - elsif page["image"].is_a?(String) - { "path" => page["image"] } - else - { "path" => nil } - end + @image_hash ||= begin + image_meta = page["image"] + + case image_meta + when Hash + { "path" => nil }.merge!(image_meta) + when String + { "path" => image_meta } + else + { "path" => nil } + end + end end alias_method :fallback_data, :image_hash diff --git a/lib/jekyll-seo-tag/json_ld_drop.rb b/lib/jekyll-seo-tag/json_ld_drop.rb index 3bd1d46..c892895 100644 --- a/lib/jekyll-seo-tag/json_ld_drop.rb +++ b/lib/jekyll-seo-tag/json_ld_drop.rb @@ -16,12 +16,12 @@ module Jekyll def_delegator :page_drop, :type, :type # Expose #type and #logo as private methods and #@type as a public method - alias_method :"@type", :type - private :type - private :logo + alias_method :@type, :type + private :type, :logo VALID_ENTITY_TYPES = %w(BlogPosting CreativeWork).freeze - private_constant :VALID_ENTITY_TYPES + VALID_AUTHOR_TYPES = %w(Organization Person).freeze + private_constant :VALID_ENTITY_TYPES, :VALID_AUTHOR_TYPES # page_drop should be an instance of Jekyll::SeoTag::Drop def initialize(page_drop) @@ -38,10 +38,18 @@ module Jekyll def author return unless page_drop.author["name"] - { - "@type" => "Person", + author_type = page_drop.author["type"] + return if author_type && !VALID_AUTHOR_TYPES.include?(author_type) + + hash = { + "@type" => author_type || "Person", "name" => page_drop.author["name"], } + + author_url = page_drop.author["url"] + hash["url"] = author_url if author_url + + hash end def image @@ -80,7 +88,7 @@ module Jekyll private :main_entity def to_json - to_h.reject { |_k, v| v.nil? }.to_json + to_h.compact.to_json end private diff --git a/lib/jekyll-seo-tag/url_helper.rb b/lib/jekyll-seo-tag/url_helper.rb index 68246cd..42bc803 100644 --- a/lib/jekyll-seo-tag/url_helper.rb +++ b/lib/jekyll-seo-tag/url_helper.rb @@ -8,8 +8,8 @@ module Jekyll # Determines if the given string is an absolute URL # - # Returns true if an absolute URL. - # Retruns false if it's a relative URL + # Returns true if an absolute URL + # Returns false if it's a relative URL # Returns nil if it is not a string or can't be parsed as a URL def absolute_url?(string) return unless string diff --git a/lib/jekyll-seo-tag/version.rb b/lib/jekyll-seo-tag/version.rb index 3a3808f..7287eb5 100644 --- a/lib/jekyll-seo-tag/version.rb +++ b/lib/jekyll-seo-tag/version.rb @@ -5,6 +5,6 @@ module Liquid; class Tag; end; end module Jekyll class SeoTag < Liquid::Tag - VERSION = "2.6.1" + VERSION = "2.7.1" end end diff --git a/lib/template.html b/lib/template.html index 2318da6..682330b 100755 --- a/lib/template.html +++ b/lib/template.html @@ -13,7 +13,7 @@ {% endif %} - + {% if seo_tag.description %} diff --git a/spec/jekyll_seo_tag/json_ld_drop_spec.rb b/spec/jekyll_seo_tag/json_ld_drop_spec.rb index 68bd275..3f1b5ff 100644 --- a/spec/jekyll_seo_tag/json_ld_drop_spec.rb +++ b/spec/jekyll_seo_tag/json_ld_drop_spec.rb @@ -69,9 +69,47 @@ RSpec.describe Jekyll::SeoTag::JSONLDDrop do expect(subject["author"]).to have_key("name") expect(subject["author"]["name"]).to be_a(String) expect(subject["author"]["name"]).to eql("author") + expect(subject["author"]["url"]).to be nil end end end + + context "when type Organization" do + let(:author) { { "name" => "organization", "type" => "Organization" } } + + it "returns the author with type" do + expect(subject).to have_key("author") + expect(subject["author"]).to be_a(Hash) + expect(subject["author"]).to have_key("@type") + expect(subject["author"]["@type"]).to eql("Organization") + expect(subject["author"]).to have_key("name") + expect(subject["author"]["name"]).to be_a(String) + expect(subject["author"]["name"]).to eql("organization") + end + end + + context "when invalid type" do + let(:author) { { "name" => "organization", "type" => "Invalid" } } + + it "returns the author with type" do + expect(subject).to have_key("author") + expect(subject["author"]).to be nil + end + end + + context "when url is present" do + let(:author) { { "name" => "author", "url" => "https://example.com" } } + + it "returns the author with url" do + expect(subject).to have_key("author") + expect(subject["author"]).to be_a(Hash) + expect(subject["author"]).to have_key("url") + expect(subject["author"]["url"]).to eql("https://example.com") + expect(subject["author"]).to have_key("name") + expect(subject["author"]["name"]).to be_a(String) + expect(subject["author"]["name"]).to eql("author") + end + end end context "image" do diff --git a/spec/jekyll_seo_tag_integration_spec.rb b/spec/jekyll_seo_tag_integration_spec.rb index 22646db..b0b9d26 100755 --- a/spec/jekyll_seo_tag_integration_spec.rb +++ b/spec/jekyll_seo_tag_integration_spec.rb @@ -8,7 +8,7 @@ RSpec.describe Jekyll::SeoTag do let(:tag) { "seo" } let(:text) { "" } let(:output) { Liquid::Template.parse("{% #{tag} #{text} %}").render!(context, {}) } - let(:json) { output.match(%r!!m)[1] } + let(:json) { output.match(%r!!m)[1] } let(:json_data) { JSON.parse(json) } let(:paginator) { { "previous_page" => true, "previous_page_path" => "foo", "next_page" => true, "next_page_path" => "bar" } } @@ -26,7 +26,8 @@ RSpec.describe Jekyll::SeoTag do end it "outputs meta generator" do - expect(output).to match(%r!Jekyll v#{Jekyll::VERSION}!i) + version = Jekyll::VERSION + expect(output).to match(%r!Jekyll v#{version}!i) end it "outputs valid HTML" do