Commit Graph

166 Commits

Author SHA1 Message Date
Kyle Niewiada 03cd692f99 Handle nil exception 2017-04-12 10:51:49 -04:00
Kyle Niewiada aa0b47bb8d Fix #187 2017-04-11 19:18:08 -04:00
Ben Balter bc0f45ae64
output image as an imageObject if we have additional image properties 2017-04-11 16:33:13 -05:00
Ben Balter 650fe5c1fd
use reduce to format strings 2017-04-11 15:19:17 -05:00
Ben Balter 8cb5953ea4
use addressible to determine absolute urls 2017-04-11 15:15:24 -05:00
Ben Balter cfe7e56cf8
better homepage_or_about detection 2017-04-11 15:13:24 -05:00
Ben Balter ab916c974e
memoize fallback_data 2017-04-11 14:59:45 -05:00
Ben Balter 0a70e8c172
remove stray begin block 2017-04-11 14:59:19 -05:00
Ben Balter ee1b03cd0a
memoize name 2017-04-11 14:58:10 -05:00
Ben Balter 993eafce00
memoize title? 2017-04-11 14:54:21 -05:00
Ben Balter d2f053dd43
add datePublished to JSON-LD schema 2017-04-10 09:58:41 -05:00
Ben Balter de12942f36
remove unused date method 2017-04-08 14:31:59 -04:00
Ben Balter 8a3cd3f9e3
specify timezone in tests 2017-04-08 14:27:45 -04:00
Ben Balter 66aff234ca
use ruby to generate json-ld 2017-04-08 14:20:21 -04:00
Ben Balter 337bffa3bc
use attr_accessor 2017-04-07 17:10:13 -04:00
Ben Balter fa44b31280
add spec for filters class 2017-04-07 17:06:03 -04:00
Ben Balter dea21f0f8d
move filters to their own class 2017-04-07 17:01:20 -04:00
Ben Balter 0fd1bdcdfc
ensure to_h doesnt cause things to explode 2017-04-07 16:51:37 -04:00
Ben Balter 7885669ee6
memoize drop 2017-04-07 16:37:21 -04:00
Ben Balter 3797b19a7d
make rubocop happy 2017-04-07 16:35:20 -04:00
Ben Balter efab796817
add image specs 2017-04-07 16:27:41 -04:00
Ben Balter 44d52ca4b7
moar tests 2017-04-07 16:20:54 -04:00
Ben Balter 326e35683f
memoize all the things 2017-04-07 13:39:05 -04:00
Ben Balter 96e9823561
add tests for drop 2017-04-06 22:34:11 -04:00
Ben Balter 058b337aba
escape urls 2017-04-06 19:07:40 -04:00
Ben Balter b9cd5de1d0
remove stubbed context 2017-04-06 19:06:31 -04:00
Ben Balter 25f1401d96
rubocop 2017-04-06 19:04:24 -04:00
Ben Balter f88db117f1
convert logic to a drop 2017-04-06 19:02:32 -04:00
Ben Balter 7ab08dcfcc
Bump to 2.2.0 2017-04-06 15:04:55 -04:00
Kyle Niewiada 61d4c91f3e Remove date default handle 2017-04-04 13:15:12 -04:00
Kyle Niewiada 9ec685a31b Merge branch 'master' into master 2017-04-04 11:51:05 -04:00
Aaron Gustafson 8a8a5e9859 Added hyphen to underscore coersion 2017-04-03 20:04:29 -04:00
Aaron Gustafson a2f64d46c3 Merge branch 'master' into add-locale-support 2017-04-03 15:10:14 -04:00
Aaron Gustafson 18ec5736c2 Variable rename 2017-04-03 15:09:35 -04:00
Kyle Niewiada ac0886dbf2 Merge branch 'master' into master 2017-04-03 13:51:25 -04:00
Ben Balter 32ec9300dc Merge pull request #174 from jhabdas/twitter-uses-og-image
refactor(template): use og:image for twitter
2017-04-03 13:51:00 -04:00
Kyle Niewiada 48ba285251 Image changes should be removed 2017-04-03 13:36:45 -04:00
Kyle Niewiada e8e54a924c Merge branch 'master' into master 2017-04-03 13:11:19 -04:00
Josh Habdas e264a9a94b
refactor(template): use og:image for twitter
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
2017-04-04 00:58:53 +08:00
Aaron Gustafson a1e5b4e53d Merge remote-tracking branch 'upstream/master' into add-locale-support 2017-04-03 11:26:11 -04:00
Aaron Gustafson abf32914b7 Switching to site.lang & page.lang to align with jekyll-feed 2017-04-03 11:21:48 -04:00
Frank Taillandier ef8fe3106c bump and appease Rubocop 2017-03-31 22:42:46 +02:00
Aaron Gustafson 2191a550ee Test cleanup 2017-03-31 14:41:46 -04:00
Aaron Gustafson 308cf7a523 Added support for locale exposure as `og:locale` 2017-03-31 14:22:08 -04:00
Kyle Niewiada 0b289b820b Merge branch 'master' into master 2017-03-03 08:16:11 -05:00
Josh Habdas 2a48f272f6
Be more explicity with title assignments 2017-03-02 21:29:26 +08:00
Josh Habdas 51db5806c2
Correct template logic, resolve style issues 2017-03-02 20:24:13 +08:00
Josh Habdas 4eeb09a749
Update title separator. Closes #121
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag

Also updates docs to specify title optional and fix errata.
2017-03-02 12:15:09 +08:00
Kyle Niewiada 4c577ffb47 Add legacy test and maintain old methods 2017-02-17 10:30:44 -05:00
Kyle Niewiada a847a69eea Fix small test case blunder. 2017-02-16 14:16:11 -05:00