Commit Graph

247 Commits

Author SHA1 Message Date
Ben Balter d893fc7646
cache parsed template 2017-08-24 13:22:59 -04:00
Ben Balter d79dac001e
whitespace 2017-08-24 13:05:56 -04:00
Ben Balter 1e5b997901
typo in code comment 2017-08-24 13:05:28 -04:00
Ben Balter 83d420113c
add json_ld back to JSONLD to avoid a breaking change 2017-08-24 13:01:43 -04:00
Ben Balter 5219dd13e6
drop the a, just JSON 2017-08-23 16:25:28 -04:00
Ben Balter 5de6cd7f2c
convert JSON LD to a drop 2017-08-23 16:11:55 -04:00
Ben Balter 298d3b03d6
Drop#image should return nil if there is no image#path in order to avoid a breaking change 2017-08-23 12:18:52 -04:00
Ben Balter 1081a0ebd9
break image logic into its own drop 2017-08-23 12:11:30 -04:00
Ben Balter 2e90fc7238
move author drop tests to their own spec 2017-08-23 11:32:36 -04:00
Ben Balter 891d621899
move author logic to its own drop 2017-08-23 11:07:52 -04:00
Ben Balter 6197b2e7a8 Merge branch 'master' into site-authors-array 2017-08-22 13:03:23 -04:00
Ben Balter 7cab0247ed
fix for image.path causing an invalid url error 2017-08-22 11:53:18 -04:00
Ben Balter a59b596a2b
comment site_author_hash 2017-08-22 11:41:02 -04:00
Ben Balter f78999819f
ensure site.data.authors is in the expected format before resolving author meta 2017-08-22 11:39:52 -04:00
Ben Balter fb7a346b48
dont use unless and else, per rubocop 2017-05-25 09:35:03 -04:00
Ben Balter 83d7c3dd63 s/if !/unless/ 2017-05-25 09:29:09 -04:00
Parth Modi ab49d7b5e8 `.present?` changed to `to_s.empty?` as `.present?` is rails specific 2017-05-24 22:35:07 +05:30
Parth Modi 62956da2de use canonical_url specified in page if present 2017-05-24 22:10:30 +05:30
Ben Balter a868ab5837
Bump to 2.2.3 2017-05-06 12:18:36 -04:00
Ben Balter 19c6d2ae04
dont double format site title 2017-05-05 09:33:44 -04:00
Ben Balter 604b23e8fc
use site_description as page_description fallback 2017-05-05 09:27:17 -04:00
Ben Balter e637154c53
memoize site_description 2017-05-05 09:25:22 -04:00
Ben Balter e68122d8ce
guard against empty strings not being nil 2017-05-05 09:24:59 -04:00
Ben Balter 4f80ea50b7
fix for calling delete! on NiLClass 2017-05-02 09:42:21 -04:00
Ben Balter 908237c7ad
Bump to 2.2.2 2017-05-01 13:00:01 -04:00
Frank Taillandier 696b361f19 Merge branch 'master' into nil-image-path-fix 2017-04-26 20:02:36 +02:00
Ben Balter 13bc107b3f
guard against invalid or missing URLs 2017-04-26 12:48:08 -04:00
Ben Balter ad25053f0b
ensure subhashes are hashes 2017-04-26 10:52:12 -04:00
Ben Balter 416a5ca687
Bump to 2.2.1 2017-04-25 11:21:29 -04:00
Frank Taillandier e0c8173de2 Merge branch 'master' into author-by-reference 2017-04-13 20:50:17 +02:00
Ben Balter a035ec02bc
fix for including name when author is passed by reference 2017-04-13 13:32:04 -04:00
Kyle Niewiada 03cd692f99 Handle nil exception 2017-04-12 10:51:49 -04:00
Kyle Niewiada aa0b47bb8d Fix #187 2017-04-11 19:18:08 -04:00
Ben Balter bc0f45ae64
output image as an imageObject if we have additional image properties 2017-04-11 16:33:13 -05:00
Ben Balter 650fe5c1fd
use reduce to format strings 2017-04-11 15:19:17 -05:00
Ben Balter 8cb5953ea4
use addressible to determine absolute urls 2017-04-11 15:15:24 -05:00
Ben Balter cfe7e56cf8
better homepage_or_about detection 2017-04-11 15:13:24 -05:00
Ben Balter ab916c974e
memoize fallback_data 2017-04-11 14:59:45 -05:00
Ben Balter 0a70e8c172
remove stray begin block 2017-04-11 14:59:19 -05:00
Ben Balter ee1b03cd0a
memoize name 2017-04-11 14:58:10 -05:00
Ben Balter 993eafce00
memoize title? 2017-04-11 14:54:21 -05:00
Ben Balter d2f053dd43
add datePublished to JSON-LD schema 2017-04-10 09:58:41 -05:00
Ben Balter de12942f36
remove unused date method 2017-04-08 14:31:59 -04:00
Ben Balter 8a3cd3f9e3
specify timezone in tests 2017-04-08 14:27:45 -04:00
Ben Balter 66aff234ca
use ruby to generate json-ld 2017-04-08 14:20:21 -04:00
Ben Balter 337bffa3bc
use attr_accessor 2017-04-07 17:10:13 -04:00
Ben Balter fa44b31280
add spec for filters class 2017-04-07 17:06:03 -04:00
Ben Balter dea21f0f8d
move filters to their own class 2017-04-07 17:01:20 -04:00
Ben Balter 0fd1bdcdfc
ensure to_h doesnt cause things to explode 2017-04-07 16:51:37 -04:00
Ben Balter 7885669ee6
memoize drop 2017-04-07 16:37:21 -04:00
Ben Balter 3797b19a7d
make rubocop happy 2017-04-07 16:35:20 -04:00
Ben Balter efab796817
add image specs 2017-04-07 16:27:41 -04:00
Ben Balter 44d52ca4b7
moar tests 2017-04-07 16:20:54 -04:00
Ben Balter 326e35683f
memoize all the things 2017-04-07 13:39:05 -04:00
Ben Balter 96e9823561
add tests for drop 2017-04-06 22:34:11 -04:00
Ben Balter 058b337aba
escape urls 2017-04-06 19:07:40 -04:00
Ben Balter b9cd5de1d0
remove stubbed context 2017-04-06 19:06:31 -04:00
Ben Balter 25f1401d96
rubocop 2017-04-06 19:04:24 -04:00
Ben Balter f88db117f1
convert logic to a drop 2017-04-06 19:02:32 -04:00
Ben Balter 7ab08dcfcc
Bump to 2.2.0 2017-04-06 15:04:55 -04:00
Kyle Niewiada 61d4c91f3e Remove date default handle 2017-04-04 13:15:12 -04:00
Kyle Niewiada 9ec685a31b Merge branch 'master' into master 2017-04-04 11:51:05 -04:00
Aaron Gustafson 8a8a5e9859 Added hyphen to underscore coersion 2017-04-03 20:04:29 -04:00
Aaron Gustafson a2f64d46c3 Merge branch 'master' into add-locale-support 2017-04-03 15:10:14 -04:00
Aaron Gustafson 18ec5736c2 Variable rename 2017-04-03 15:09:35 -04:00
Kyle Niewiada ac0886dbf2 Merge branch 'master' into master 2017-04-03 13:51:25 -04:00
Ben Balter 32ec9300dc Merge pull request #174 from jhabdas/twitter-uses-og-image
refactor(template): use og:image for twitter
2017-04-03 13:51:00 -04:00
Kyle Niewiada 48ba285251 Image changes should be removed 2017-04-03 13:36:45 -04:00
Kyle Niewiada e8e54a924c Merge branch 'master' into master 2017-04-03 13:11:19 -04:00
Josh Habdas e264a9a94b
refactor(template): use og:image for twitter
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
2017-04-04 00:58:53 +08:00
Aaron Gustafson a1e5b4e53d Merge remote-tracking branch 'upstream/master' into add-locale-support 2017-04-03 11:26:11 -04:00
Aaron Gustafson abf32914b7 Switching to site.lang & page.lang to align with jekyll-feed 2017-04-03 11:21:48 -04:00
Frank Taillandier ef8fe3106c bump and appease Rubocop 2017-03-31 22:42:46 +02:00
Aaron Gustafson 2191a550ee Test cleanup 2017-03-31 14:41:46 -04:00
Aaron Gustafson 308cf7a523 Added support for locale exposure as `og:locale` 2017-03-31 14:22:08 -04:00
Kyle Niewiada 0b289b820b Merge branch 'master' into master 2017-03-03 08:16:11 -05:00
Josh Habdas 2a48f272f6
Be more explicity with title assignments 2017-03-02 21:29:26 +08:00
Josh Habdas 51db5806c2
Correct template logic, resolve style issues 2017-03-02 20:24:13 +08:00
Josh Habdas 4eeb09a749
Update title separator. Closes #121
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag

Also updates docs to specify title optional and fix errata.
2017-03-02 12:15:09 +08:00
Kyle Niewiada 4c577ffb47 Add legacy test and maintain old methods 2017-02-17 10:30:44 -05:00
Kyle Niewiada a847a69eea Fix small test case blunder. 2017-02-16 14:16:11 -05:00
Kyle Niewiada ba16b955c8 Propose new image handling method. 2017-02-16 14:07:35 -05:00
Kyle Niewiada 8e36fe4da1 Update docs. Add use case. Add test. 2017-02-15 12:41:30 -05:00
Kyle Niewiada cc02710dbf Merge branch 'master' into master 2017-02-15 10:00:52 -05:00
Ben Balter fa96401540
Merge branch 'master' of https://github.com/renshuki/jekyll-seo-tag into renshuki-master 2017-02-13 10:04:12 -05:00
Kyle Niewiada 987e1ea81c Merge branch 'master' into master 2017-01-30 10:38:18 -05:00
kyle da498c7c5f Simplify documentation. Change to snake_case. Use Path instead of adding URL. 2017-01-30 10:37:27 -05:00
renshuki e91babe998 Fix rubocop multiline hash errors 2017-01-30 10:53:19 +09:00
renshuki 903f9efab9 Implement seo_author.name 2017-01-29 04:33:50 +09:00
renshuki 81c9bc8fa4 Add author meta 2017-01-29 02:57:04 +09:00
kyle a0f65888e3 Remove Author tag. I guess it really isn't used anymore. 2017-01-25 12:18:29 -05:00
kyle 5437934214 Implement PR #103 for my own use. Change template to better fit existing style. 2017-01-25 11:35:18 -05:00
kyle fd5246a4cd Test output manually with Google Markup. Change inferred type. Improve test coverage 2017-01-25 11:05:38 -05:00
kyle 9aa2cbfb09 Wite tests for implemented features. 2017-01-18 14:57:36 -05:00
Kyle Niewiada 30d4ffc1a3 Fix language mistake
Well.... looks like I added an 'e'. Whoops.
2017-01-17 09:50:54 -05:00
Kyle Niewiada 4868d22b1b Add the rest of the JSON tags to pass blogPosting Errors/Warnings
This adds the rest of the JSON fields to pass all errors and blog postings.

- Adds page.image.url for the image url. (Will default to image if not present). 
- Add page.image.height and page.image.width for an image object (Will default back to image url if not present). 
- Add dateModified (will capture from yaml if present, if not it will use datePublished)
  - (I feel there should be a manual option for this as I sometimes save parts of my blog that shouldn't update the modified field, but still 
change the file timestamp).

This should create JSON that will pass all warnings/strong recommendations/errors from [Google's Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool).
2017-01-17 09:39:41 -05:00
Kyle Niewiada 2ddab030f3 Fix word casing 2017-01-16 17:49:37 -05:00
Kyle Niewiada 8d2febf86c Fix typo. Oops. 2017-01-16 17:21:08 -05:00
Kyle Niewiada f82ea47534 Fix Google Structured Data Requests
Fixes missing author and name in blogPosting types with organization.
2017-01-16 17:18:50 -05:00
Josh Habdas a321a7f2f7
Incorporate feedback, add unit tests 2017-01-13 12:48:55 +08:00