adamsdesk
/
jekyll-seo-tag
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
390 Commits 8 Branches 27 Tags 1 MiB
Commit Graph

126 Commits

Author SHA1 Message Date
Ben Balter fb7a346b48
dont use unless and else, per rubocop 2017-05-25 09:35:03 -04:00
Ben Balter 245abc6032
update canoncial URL expectation 2017-05-25 09:34:18 -04:00
Ben Balter bf6b14b167 Explicitly test both canonical URL cases 2017-05-25 09:33:03 -04:00
Parth Modi c07a085e11 Stray puts removed from test of canonical url 2017-05-24 22:35:32 +05:30
Parth Modi 1e6110ddef rubocop offenses fixed 2017-05-24 22:20:44 +05:30
Parth Modi 62956da2de use canonical_url specified in page if present 2017-05-24 22:10:30 +05:30
Ben Balter e68122d8ce
guard against empty strings not being nil 2017-05-05 09:24:59 -04:00
Ben Balter 96b1fa22c5
add explicit test for all descriptions being nil 2017-05-03 09:08:40 -04:00
Ben Balter 65820ada36
Add failing test for https://github.com/jekyll/jekyll-seo-tag/issues/202 2017-05-02 09:41:18 -04:00
Frank Taillandier 696b361f19 Merge branch 'master' into nil-image-path-fix 2017-04-26 20:02:36 +02:00
Ben Balter d00191c1e3
update failing tests for bad URLs 2017-04-26 12:48:00 -04:00
Ben Balter 593d09aacc
failing test for nil image paths 2017-04-26 12:43:10 -04:00
Ben Balter b3c2cec0a0
update test expectations 2017-04-26 10:52:03 -04:00
Ben Balter c2f6d1a795
failing test for site.social and page.seo being arrays 2017-04-26 10:45:23 -04:00
Ben Balter a035ec02bc
fix for including name when author is passed by reference 2017-04-13 13:32:04 -04:00
Ben Balter 812eb22200
add test for front matter defaults 2017-04-13 11:36:49 -04:00
Ben Balter bc0f45ae64
output image as an imageObject if we have additional image properties 2017-04-11 16:33:13 -05:00
Ben Balter 0f8edbce4a
add test for specifying image height and width 2017-04-11 15:29:43 -05:00
Ben Balter cfe7e56cf8
better homepage_or_about detection 2017-04-11 15:13:24 -05:00
Ben Balter 791db5107c
check author passed as a hash in json-ld 2017-04-11 14:45:49 -05:00
Ben Balter d2f053dd43
add datePublished to JSON-LD schema 2017-04-10 09:58:41 -05:00
Ben Balter 9c06b710e6
call it an integration spec 2017-04-08 14:29:53 -04:00
Ben Balter 6eaae965f8
silence Jekyll output 2017-04-08 14:29:24 -04:00
Ben Balter 8a3cd3f9e3
specify timezone in tests 2017-04-08 14:27:45 -04:00
Ben Balter 66aff234ca
use ruby to generate json-ld 2017-04-08 14:20:21 -04:00
Ben Balter fa44b31280
add spec for filters class 2017-04-07 17:06:03 -04:00
Ben Balter 0fd1bdcdfc
ensure to_h doesnt cause things to explode 2017-04-07 16:51:37 -04:00
Ben Balter 9620da0224
simplify tests 2017-04-07 16:34:01 -04:00
Ben Balter efab796817
add image specs 2017-04-07 16:27:41 -04:00
Ben Balter 44d52ca4b7
moar tests 2017-04-07 16:20:54 -04:00
Ben Balter 96e9823561
add tests for drop 2017-04-06 22:34:11 -04:00
Kyle Niewiada 9ec685a31b Merge branch 'master' into master 2017-04-04 11:51:05 -04:00
Ben Balter 8e8b11aab7
update to use new html proofer api 2017-04-04 09:52:27 -04:00
Ben Balter 7de7c7a497
require html-proofer, not html/proofer 2017-04-04 09:50:57 -04:00
Aaron Gustafson 4f919b2aaa Anticitating Rubocop 2017-04-03 20:05:24 -04:00
Aaron Gustafson 8a8a5e9859 Added hyphen to underscore coersion 2017-04-03 20:04:29 -04:00
Kyle Niewiada 6009b495ea Separate tests. 2017-04-03 15:25:57 -04:00
Aaron Gustafson a2f64d46c3 Merge branch 'master' into add-locale-support 2017-04-03 15:10:14 -04:00
Kyle Niewiada ac0886dbf2 Merge branch 'master' into master 2017-04-03 13:51:25 -04:00
Ben Balter 32ec9300dc Merge pull request #174 from jhabdas/twitter-uses-og-image 
refactor(template): use og:image for twitter
 2017-04-03 13:51:00 -04:00
Kyle Niewiada 48ba285251 Image changes should be removed 2017-04-03 13:36:45 -04:00
Josh Habdas e264a9a94b
refactor(template): use og:image for twitter 
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
 2017-04-04 00:58:53 +08:00
Aaron Gustafson b3d5db3563 Fixing Rubocop offenses 2017-04-03 11:32:31 -04:00
Aaron Gustafson abf32914b7 Switching to site.lang & page.lang to align with jekyll-feed 2017-04-03 11:21:48 -04:00
Aaron Gustafson 2191a550ee Test cleanup 2017-03-31 14:41:46 -04:00
Aaron Gustafson 59b20c7bf9 Added test 2017-03-31 14:26:58 -04:00
Kyle Niewiada 0b289b820b Merge branch 'master' into master 2017-03-03 08:16:11 -05:00
Josh Habdas 51db5806c2
Correct template logic, resolve style issues 2017-03-02 20:24:13 +08:00
Josh Habdas 4eeb09a749
Update title separator. Closes #121 
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag

Also updates docs to specify title optional and fix errata.
 2017-03-02 12:15:09 +08:00
Kyle Niewiada c31f4c65b1 Better test coverage. Some overlap, but easier to understand. Some tests slightly refactored. 2017-02-24 15:04:36 -05:00