Commit Graph

158 Commits

Author SHA1 Message Date
Ben Balter cfe7e56cf8
better homepage_or_about detection 2017-04-11 15:13:24 -05:00
Ben Balter 791db5107c
check author passed as a hash in json-ld 2017-04-11 14:45:49 -05:00
Ben Balter d2f053dd43
add datePublished to JSON-LD schema 2017-04-10 09:58:41 -05:00
Ben Balter 9c06b710e6
call it an integration spec 2017-04-08 14:29:53 -04:00
Ben Balter 6eaae965f8
silence Jekyll output 2017-04-08 14:29:24 -04:00
Ben Balter 8a3cd3f9e3
specify timezone in tests 2017-04-08 14:27:45 -04:00
Ben Balter 66aff234ca
use ruby to generate json-ld 2017-04-08 14:20:21 -04:00
Ben Balter fa44b31280
add spec for filters class 2017-04-07 17:06:03 -04:00
Ben Balter 0fd1bdcdfc
ensure to_h doesnt cause things to explode 2017-04-07 16:51:37 -04:00
Ben Balter 9620da0224
simplify tests 2017-04-07 16:34:01 -04:00
Ben Balter efab796817
add image specs 2017-04-07 16:27:41 -04:00
Ben Balter 44d52ca4b7
moar tests 2017-04-07 16:20:54 -04:00
Ben Balter 96e9823561
add tests for drop 2017-04-06 22:34:11 -04:00
Kyle Niewiada 9ec685a31b Merge branch 'master' into master 2017-04-04 11:51:05 -04:00
Ben Balter 8e8b11aab7
update to use new html proofer api 2017-04-04 09:52:27 -04:00
Ben Balter 7de7c7a497
require html-proofer, not html/proofer 2017-04-04 09:50:57 -04:00
Aaron Gustafson 4f919b2aaa Anticitating Rubocop 2017-04-03 20:05:24 -04:00
Aaron Gustafson 8a8a5e9859 Added hyphen to underscore coersion 2017-04-03 20:04:29 -04:00
Kyle Niewiada 6009b495ea Separate tests. 2017-04-03 15:25:57 -04:00
Aaron Gustafson a2f64d46c3 Merge branch 'master' into add-locale-support 2017-04-03 15:10:14 -04:00
Kyle Niewiada ac0886dbf2 Merge branch 'master' into master 2017-04-03 13:51:25 -04:00
Ben Balter 32ec9300dc Merge pull request #174 from jhabdas/twitter-uses-og-image
refactor(template): use og:image for twitter
2017-04-03 13:51:00 -04:00
Kyle Niewiada 48ba285251 Image changes should be removed 2017-04-03 13:36:45 -04:00
Josh Habdas e264a9a94b
refactor(template): use og:image for twitter
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
2017-04-04 00:58:53 +08:00
Aaron Gustafson b3d5db3563 Fixing Rubocop offenses 2017-04-03 11:32:31 -04:00
Aaron Gustafson abf32914b7 Switching to site.lang & page.lang to align with jekyll-feed 2017-04-03 11:21:48 -04:00
Aaron Gustafson 2191a550ee Test cleanup 2017-03-31 14:41:46 -04:00
Aaron Gustafson 59b20c7bf9 Added test 2017-03-31 14:26:58 -04:00
Kyle Niewiada 0b289b820b Merge branch 'master' into master 2017-03-03 08:16:11 -05:00
Josh Habdas 51db5806c2
Correct template logic, resolve style issues 2017-03-02 20:24:13 +08:00
Josh Habdas 4eeb09a749
Update title separator. Closes #121
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag

Also updates docs to specify title optional and fix errata.
2017-03-02 12:15:09 +08:00
Kyle Niewiada c31f4c65b1 Better test coverage. Some overlap, but easier to understand. Some tests slightly refactored. 2017-02-24 15:04:36 -05:00
Kyle Niewiada 3410feec97 Merge branch 'master' into master 2017-02-21 21:47:05 -05:00
renshuki 87b4cd7807 Add specs for author metadata 2017-02-18 18:13:50 +09:00
Kyle Niewiada 02eb926293 Appease RuboCop 2017-02-17 10:33:39 -05:00
Kyle Niewiada 4c577ffb47 Add legacy test and maintain old methods 2017-02-17 10:30:44 -05:00
Kyle Niewiada a847a69eea Fix small test case blunder. 2017-02-16 14:16:11 -05:00
Kyle Niewiada ba16b955c8 Propose new image handling method. 2017-02-16 14:07:35 -05:00
Kyle Niewiada 8e36fe4da1 Update docs. Add use case. Add test. 2017-02-15 12:41:30 -05:00
kyle 6ebc866c5e Appease RuboCop 2017-01-30 10:46:22 -05:00
Kyle Niewiada 987e1ea81c Merge branch 'master' into master 2017-01-30 10:38:18 -05:00
kyle da498c7c5f Simplify documentation. Change to snake_case. Use Path instead of adding URL. 2017-01-30 10:37:27 -05:00
renshuki e91babe998 Fix rubocop multiline hash errors 2017-01-30 10:53:19 +09:00
kyle a0f65888e3 Remove Author tag. I guess it really isn't used anymore. 2017-01-25 12:18:29 -05:00
kyle 644e976fbd Add test for PR #103 2017-01-25 11:37:35 -05:00
kyle 5437934214 Implement PR #103 for my own use. Change template to better fit existing style. 2017-01-25 11:35:18 -05:00
kyle fd5246a4cd Test output manually with Google Markup. Change inferred type. Improve test coverage 2017-01-25 11:05:38 -05:00
kyle b04f73960e Match rubocop styling. 2017-01-18 15:28:54 -05:00
kyle 10d5f82984 Travis doesn't like my timestamps for testing. 2017-01-18 15:01:48 -05:00
kyle 9aa2cbfb09 Wite tests for implemented features. 2017-01-18 14:57:36 -05:00
kyle 8cc9b2d52c Add test for image object with dimensions 2017-01-18 14:14:29 -05:00
Josh Habdas a321a7f2f7
Incorporate feedback, add unit tests 2017-01-13 12:48:55 +08:00
Pat Hawks f90fb32d25
Update tests for new position of logo 2016-10-23 14:48:11 -05:00
Pat Hawks 07eeffb6d9
Simplify minify regex 2016-10-15 14:24:13 -05:00
Pat Hawks df09740757
Take advantage of Jekyll 3.3.0 URL filters 2016-10-06 15:56:15 -05:00
Pat Hawks b019a653af
Fix broken test 2016-10-06 15:47:49 -05:00
Ben Balter 2631e3ea77 run rubocop -a 2016-09-08 11:33:03 -04:00
Ben Balter 53e807a99a Inherit Jekyll's rubocop config for consistency 2016-08-11 11:35:31 -04:00
Todd Eichel 73608f8ca1
Appease rubocop. 2016-05-27 15:09:59 -07:00
Todd Eichel c58f44d9a3
Oops, that wasn't as backwards compatible as I thought. 2016-05-27 15:04:56 -07:00
Todd Eichel 7fefcdef3f
Specs for pagination. 2016-05-27 15:00:15 -07:00
Todd Eichel edd65c3f14
Allow passing custom environments when making Liquid contexts for testing. Backwards-compatible with previous implementation. 2016-05-27 14:59:39 -07:00
Todd Eichel b55105813a
Move this individual spec up with other individual ones. 2016-05-27 12:17:52 -07:00
Miguel Flores Ruiz de Eguino f772747728 Add facebook admins meta tag to template and facebook spec 2016-05-11 13:05:40 -05:00
Pat Hawks d0160082cc
Add support for page images with absolute URLs 2016-04-25 08:15:32 -07:00
Ben Balter 450d3f8fca run rubocop 2016-04-25 10:03:29 -04:00
Ben Balter cb81364a77 add tests 2016-04-19 10:05:21 -04:00
Bo Turnbow ad5add0540
Add tests for large image Twitter card 2016-03-05 12:19:14 -08:00
Bo Turnbow 54effa1abd Merge branch 'master' into master 2016-03-02 15:50:51 -07:00
Pat Hawks 556b8e45fa
Use current version in minify test 2016-03-02 09:13:12 -08:00
Pat Hawks 55ead7fcb8
Remove obsolete twitter:image test 2016-03-01 21:20:31 -08:00
XhmikosR 5fb86bfa7b Be consistent with the quotes in output. 2016-03-01 18:47:37 +02:00
XhmikosR dae68cb01e Remove spaces before `:`. 2016-03-01 18:31:12 +02:00
Bo Turnbow 4cb0b75bfa Update JSON-LD output to current usage for site logo and page image 2016-02-26 16:13:29 -07:00
Ben Balter 1e6b9e55e9 minify json ld and test 2016-02-25 13:56:13 -05:00
Ben Balter 38afc5a4d0 Merge pull request #28 from jekyll/pr/json-ld
Consolidate and clean up JSON-LD
2016-02-25 10:50:37 -05:00
Bo Turnbow 2d0101bd1e Change site logo to expect a rooted url 2016-02-23 15:57:25 -07:00
Bo Turnbow b42501b45a Per Ben Balter, change usage to a rooted image url 2016-02-23 15:54:17 -07:00
Bo Turnbow 738f4efea7 Update twitter:image to output full url 2016-02-23 11:54:52 -07:00
Pat Hawks f3e0e78993
Include sameAs links on About page 2016-02-22 18:13:43 -08:00
Pat Hawks c51ef4db83 Fix JSON-LD tests
There is no reason to test for `site` variables each time we check
JSON-LD. Let's only test what we say we are going to test at each stage.
2016-02-22 17:59:12 -08:00
Ben Balter 81be1da466 use title=false, not title: false 2016-02-21 14:25:15 -05:00
Ben Balter 6bc8a57315 Merge branch 'master' into pr/title-optional 2016-02-21 14:16:00 -05:00
Ben Balter f1cdf62b53 add support for authors an an array 2016-02-21 13:52:49 -05:00
Ben Balter 068a1b972a add tests 2016-02-20 17:24:08 -05:00
Ben Balter 7568f6b618 better json parsing 2016-02-20 15:52:16 -05:00
Ben Balter 0ded70bd7e better specs 2016-02-20 15:49:55 -05:00
Ben Balter bdedd23bf2 expose version in HTML comment 2016-02-20 14:26:06 -05:00
Ben Balter f9bcb30d61 add rubocop 2016-02-09 18:48:24 -05:00
Ben Balter 79b177b248 add content to fixtures 2016-02-09 18:20:34 -05:00
Ben Balter 5ed2ab3d6c Merge pull request #44 from boturnbow/relative_image_tag
Make page.image url relative to site rather than absolute
2016-02-03 12:31:02 -05:00
Ben Balter 31dc2491c5 Merge pull request #43 from pathawks/pr/jekyll3
Update tests to work with Liquid 3
2016-02-03 12:30:16 -05:00
Bo Turnbow 244802ed89 Make page.image url relative to site rather than absolute 2016-02-03 10:17:04 -07:00
Pat Hawks a42df44513
Update tests to work with Jekyll 3 2016-02-02 20:02:08 -08:00
Pat Hawks 6d2f5aee1b
Update tests to work with Liquid 3 2016-02-02 19:06:10 -08:00
Carlos Garcés eac9501a2d Fix travis-ci errors 2016-01-30 22:50:19 +01:00
Parker Moore 6dab82639e use the page.excerpt if the page.description doesn't exist 2016-01-25 14:29:48 -08:00
Pat Hawks 66384741c3
Make <title> optional 2016-01-12 23:09:28 -08:00
Pat Hawks 5638c19a5d
Allow author data as an object 2016-01-12 12:09:43 -08:00
Ben Balter 9f53718796 Merge pull request #21 from benbalter/entities
Do not escape smart quotes
2016-01-12 10:58:24 -05:00