Ben Balter
9620da0224
simplify tests
2017-04-07 16:34:01 -04:00
Ben Balter
efab796817
add image specs
2017-04-07 16:27:41 -04:00
Ben Balter
44d52ca4b7
moar tests
2017-04-07 16:20:54 -04:00
Ben Balter
96e9823561
add tests for drop
2017-04-06 22:34:11 -04:00
Kyle Niewiada
9ec685a31b
Merge branch 'master' into master
2017-04-04 11:51:05 -04:00
Ben Balter
8e8b11aab7
update to use new html proofer api
2017-04-04 09:52:27 -04:00
Ben Balter
7de7c7a497
require html-proofer, not html/proofer
2017-04-04 09:50:57 -04:00
Aaron Gustafson
4f919b2aaa
Anticitating Rubocop
2017-04-03 20:05:24 -04:00
Aaron Gustafson
8a8a5e9859
Added hyphen to underscore coersion
2017-04-03 20:04:29 -04:00
Kyle Niewiada
6009b495ea
Separate tests.
2017-04-03 15:25:57 -04:00
Aaron Gustafson
a2f64d46c3
Merge branch 'master' into add-locale-support
2017-04-03 15:10:14 -04:00
Kyle Niewiada
ac0886dbf2
Merge branch 'master' into master
2017-04-03 13:51:25 -04:00
Ben Balter
32ec9300dc
Merge pull request #174 from jhabdas/twitter-uses-og-image
...
refactor(template): use og:image for twitter
2017-04-03 13:51:00 -04:00
Kyle Niewiada
48ba285251
Image changes should be removed
2017-04-03 13:36:45 -04:00
Josh Habdas
e264a9a94b
refactor(template): use og:image for twitter
...
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151 . Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151 .
Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
2017-04-04 00:58:53 +08:00
Aaron Gustafson
b3d5db3563
Fixing Rubocop offenses
2017-04-03 11:32:31 -04:00
Aaron Gustafson
abf32914b7
Switching to site.lang & page.lang to align with jekyll-feed
2017-04-03 11:21:48 -04:00
Aaron Gustafson
2191a550ee
Test cleanup
2017-03-31 14:41:46 -04:00
Aaron Gustafson
59b20c7bf9
Added test
2017-03-31 14:26:58 -04:00
Kyle Niewiada
0b289b820b
Merge branch 'master' into master
2017-03-03 08:16:11 -05:00
Josh Habdas
51db5806c2
Correct template logic, resolve style issues
2017-03-02 20:24:13 +08:00
Josh Habdas
4eeb09a749
Update title separator. Closes #121
...
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag
Also updates docs to specify title optional and fix errata.
2017-03-02 12:15:09 +08:00
Kyle Niewiada
c31f4c65b1
Better test coverage. Some overlap, but easier to understand. Some tests slightly refactored.
2017-02-24 15:04:36 -05:00
Kyle Niewiada
3410feec97
Merge branch 'master' into master
2017-02-21 21:47:05 -05:00
renshuki
87b4cd7807
Add specs for author metadata
2017-02-18 18:13:50 +09:00
Kyle Niewiada
02eb926293
Appease RuboCop
2017-02-17 10:33:39 -05:00
Kyle Niewiada
4c577ffb47
Add legacy test and maintain old methods
2017-02-17 10:30:44 -05:00
Kyle Niewiada
a847a69eea
Fix small test case blunder.
2017-02-16 14:16:11 -05:00
Kyle Niewiada
ba16b955c8
Propose new image handling method.
2017-02-16 14:07:35 -05:00
Kyle Niewiada
8e36fe4da1
Update docs. Add use case. Add test.
2017-02-15 12:41:30 -05:00
kyle
6ebc866c5e
Appease RuboCop
2017-01-30 10:46:22 -05:00
Kyle Niewiada
987e1ea81c
Merge branch 'master' into master
2017-01-30 10:38:18 -05:00
kyle
da498c7c5f
Simplify documentation. Change to snake_case. Use Path instead of adding URL.
2017-01-30 10:37:27 -05:00
renshuki
e91babe998
Fix rubocop multiline hash errors
2017-01-30 10:53:19 +09:00
kyle
a0f65888e3
Remove Author tag. I guess it really isn't used anymore.
2017-01-25 12:18:29 -05:00
kyle
644e976fbd
Add test for PR #103
2017-01-25 11:37:35 -05:00
kyle
5437934214
Implement PR #103 for my own use. Change template to better fit existing style.
2017-01-25 11:35:18 -05:00
kyle
fd5246a4cd
Test output manually with Google Markup. Change inferred type. Improve test coverage
2017-01-25 11:05:38 -05:00
kyle
b04f73960e
Match rubocop styling.
2017-01-18 15:28:54 -05:00
kyle
10d5f82984
Travis doesn't like my timestamps for testing.
2017-01-18 15:01:48 -05:00
kyle
9aa2cbfb09
Wite tests for implemented features.
2017-01-18 14:57:36 -05:00
kyle
8cc9b2d52c
Add test for image object with dimensions
2017-01-18 14:14:29 -05:00
Josh Habdas
a321a7f2f7
Incorporate feedback, add unit tests
2017-01-13 12:48:55 +08:00
Pat Hawks
f90fb32d25
Update tests for new position of logo
2016-10-23 14:48:11 -05:00
Pat Hawks
07eeffb6d9
Simplify minify regex
2016-10-15 14:24:13 -05:00
Pat Hawks
df09740757
Take advantage of Jekyll 3.3.0 URL filters
2016-10-06 15:56:15 -05:00
Pat Hawks
b019a653af
Fix broken test
2016-10-06 15:47:49 -05:00
Ben Balter
2631e3ea77
run rubocop -a
2016-09-08 11:33:03 -04:00
Ben Balter
53e807a99a
Inherit Jekyll's rubocop config for consistency
2016-08-11 11:35:31 -04:00
Todd Eichel
73608f8ca1
Appease rubocop.
2016-05-27 15:09:59 -07:00