Commit Graph

579 Commits

Author SHA1 Message Date
Kyle Niewiada 6009b495ea Separate tests. 2017-04-03 15:25:57 -04:00
Aaron Gustafson a2f64d46c3 Merge branch 'master' into add-locale-support 2017-04-03 15:10:14 -04:00
Aaron Gustafson 18ec5736c2 Variable rename 2017-04-03 15:09:35 -04:00
Aaron Gustafson e2114abbb7 Fixing the documentation 2017-04-03 14:41:21 -04:00
Kyle Niewiada bc32658d36 Clarify documentation 2017-04-03 14:25:29 -04:00
Kyle Niewiada ac0886dbf2 Merge branch 'master' into master 2017-04-03 13:51:25 -04:00
Ben Balter 32ec9300dc Merge pull request #174 from jhabdas/twitter-uses-og-image
refactor(template): use og:image for twitter
2017-04-03 13:51:00 -04:00
Kyle Niewiada 48ba285251 Image changes should be removed 2017-04-03 13:36:45 -04:00
Kyle Niewiada e8e54a924c Merge branch 'master' into master 2017-04-03 13:11:19 -04:00
Josh Habdas e264a9a94b
refactor(template): use og:image for twitter
#77 and #78 added support for different images on Twitter and Facebook, an advanced feature of SEO
Tag Gem. The implementation has led to complications updating JSON-LD data in #151. Under Pareto
principal we can reasonably assume this feature is not often used, and, as such, should be removed.
The result of which simplifies template logic, offers a fallback experience by leverages Twitter's
use of `og:image` in place of `twitter:image` (sees twitter card tag ref) and helps unblock #151.

Users can no longer specify a separate twitter and Facebook image. If both a Facebook (Open Graph)
and Twitter image are provided in the `image` object, the Facebook image will take precedence.
2017-04-04 00:58:53 +08:00
Aaron Gustafson b3d5db3563 Fixing Rubocop offenses 2017-04-03 11:32:31 -04:00
Aaron Gustafson a1e5b4e53d Merge remote-tracking branch 'upstream/master' into add-locale-support 2017-04-03 11:26:11 -04:00
Aaron Gustafson abf32914b7 Switching to site.lang & page.lang to align with jekyll-feed 2017-04-03 11:21:48 -04:00
Aaron Gustafson 8a5b022a89 Adding /bin/ to mask local testing 2017-04-03 11:11:59 -04:00
Ben Balter dc767f10cc Merge pull request #170 from DirtyF/rubocop-offenses
bump and appease Rubocop
2017-04-03 09:59:59 -04:00
Frank Taillandier 4be9613191 Disable Style/IndentHeredoc on specs 2017-03-31 23:55:49 +02:00
Frank Taillandier ef8fe3106c bump and appease Rubocop 2017-03-31 22:42:46 +02:00
Frank Taillandier 2172ada23b bump dev dependencies 2017-03-31 22:34:43 +02:00
Frank Taillandier 5f3260809e No need to delete Jekyll's version from Gemfile
Github Pages supports Jekyll 3.4.3
2017-03-31 21:39:22 +02:00
Aaron Gustafson 2191a550ee Test cleanup 2017-03-31 14:41:46 -04:00
Aaron Gustafson 179530d885 Added documentation 2017-03-31 14:31:16 -04:00
Aaron Gustafson 59b20c7bf9 Added test 2017-03-31 14:26:58 -04:00
Aaron Gustafson 308cf7a523 Added support for locale exposure as `og:locale` 2017-03-31 14:22:08 -04:00
Kyle Niewiada 0b289b820b Merge branch 'master' into master 2017-03-03 08:16:11 -05:00
Ben Balter 4aedc4f7e3 Merge pull request #162 from jhabdas/moz-separator
Update title separator. Closes #121
2017-03-02 11:12:01 -05:00
Josh Habdas 2a48f272f6
Be more explicity with title assignments 2017-03-02 21:29:26 +08:00
Josh Habdas 51db5806c2
Correct template logic, resolve style issues 2017-03-02 20:24:13 +08:00
Josh Habdas 4eeb09a749
Update title separator. Closes #121
Replaces the "-" used as a title separator with "|".
Ref: https://moz.com/learn/seo/title-tag

Also updates docs to specify title optional and fix errata.
2017-03-02 12:15:09 +08:00
Kyle Niewiada 74c2d3dbe7 Code deprecated note 2017-02-25 10:23:40 -05:00
Kyle Niewiada 89aad3b9e0 Merge pull request #1 from aav7fl/testing
Better test coverage. Refactored.
2017-02-24 15:06:32 -05:00
Kyle Niewiada c31f4c65b1 Better test coverage. Some overlap, but easier to understand. Some tests slightly refactored. 2017-02-24 15:04:36 -05:00
Kyle Niewiada 3410feec97 Merge branch 'master' into master 2017-02-21 21:47:05 -05:00
Ben Balter a814dc6f0f Merge pull request #160 from renshuki/metaname-author-unit-tests
Add specs for author metadata
2017-02-21 11:00:55 -05:00
renshuki 87b4cd7807 Add specs for author metadata 2017-02-18 18:13:50 +09:00
Kyle Niewiada 02eb926293 Appease RuboCop 2017-02-17 10:33:39 -05:00
Kyle Niewiada 4c577ffb47 Add legacy test and maintain old methods 2017-02-17 10:30:44 -05:00
Kyle Niewiada 318de343b0 Remove unnecessary/confusing wording. 2017-02-16 14:49:06 -05:00
Kyle Niewiada a847a69eea Fix small test case blunder. 2017-02-16 14:16:11 -05:00
Kyle Niewiada ba16b955c8 Propose new image handling method. 2017-02-16 14:07:35 -05:00
Kyle Niewiada 8e36fe4da1 Update docs. Add use case. Add test. 2017-02-15 12:41:30 -05:00
Kyle Niewiada cc02710dbf Merge branch 'master' into master 2017-02-15 10:00:52 -05:00
Ben Balter 7a55ccd04d Update history to reflect merge of #103 2017-02-13 10:07:16 -05:00
Ben Balter 0acae1650a
Merge branch 'renshuki-master' 2017-02-13 10:05:56 -05:00
Ben Balter fa96401540
Merge branch 'master' of https://github.com/renshuki/jekyll-seo-tag into renshuki-master 2017-02-13 10:04:12 -05:00
kyle 6ebc866c5e Appease RuboCop 2017-01-30 10:46:22 -05:00
Kyle Niewiada 987e1ea81c Merge branch 'master' into master 2017-01-30 10:38:18 -05:00
kyle da498c7c5f Simplify documentation. Change to snake_case. Use Path instead of adding URL. 2017-01-30 10:37:27 -05:00
Ben Balter 143451a12e Merge pull request #157 from renshuki/fix-rubocop-multiline-hash-errors
Fix rubocop multiline hash errors
2017-01-30 09:53:18 -05:00
renshuki e91babe998 Fix rubocop multiline hash errors 2017-01-30 10:53:19 +09:00
renshuki 903f9efab9 Implement seo_author.name 2017-01-29 04:33:50 +09:00