From 69736d68aab96ad75e3980990a8a5d034c80afab Mon Sep 17 00:00:00 2001
From: Roberto Previdi <hariseldon78@gmail.com>
Date: Wed, 13 Sep 2023 18:20:13 +0200
Subject: [PATCH] Update workspaces.cpp

Fix unchecked string to int conversion of workspace name (which can be a string)
Closes #2501
---
 src/modules/hyprland/workspaces.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/modules/hyprland/workspaces.cpp b/src/modules/hyprland/workspaces.cpp
index b7ffa5f8..f38b5050 100644
--- a/src/modules/hyprland/workspaces.cpp
+++ b/src/modules/hyprland/workspaces.cpp
@@ -439,7 +439,6 @@ void Workspaces::sort_workspaces() {
               // Helper comparisons
               auto is_id_less = a->id() < b->id();
               auto is_name_less = a->name() < b->name();
-              auto is_number_less = std::stoi(a->name()) < std::stoi(b->name());
 
               switch (sort_by_) {
                 case SORT_METHOD::ID:
@@ -448,7 +447,7 @@ void Workspaces::sort_workspaces() {
                   return is_name_less;
                 case SORT_METHOD::NUMBER:
                   try {
-                    return is_number_less;
+                    return std::stoi(a->name()) < std::stoi(b->name());
                   } catch (const std::invalid_argument &) {
                     // Handle the exception if necessary.
                     break;