From 01d45062531f8da120343a9ce8d75b12eafcc8da Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Tue, 14 Apr 2020 18:44:40 +0200 Subject: [PATCH] render/drm_format_set: disallow DRM_FORMAT_INVALID It doesn't make sense to add DRM_FORMAT_INVALID to a format set. Adding an assertion allows us to safely query the format set with DRM_FORMAT_INVALID. See [1]. [1]: https://github.com/swaywm/wlroots/pull/2021#discussion_r385839668 --- render/drm_format_set.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/render/drm_format_set.c b/render/drm_format_set.c index b09a68a4..cbcc0875 100644 --- a/render/drm_format_set.c +++ b/render/drm_format_set.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -57,6 +58,7 @@ bool wlr_drm_format_set_has(const struct wlr_drm_format_set *set, bool wlr_drm_format_set_add(struct wlr_drm_format_set *set, uint32_t format, uint64_t modifier) { + assert(format != DRM_FORMAT_INVALID); struct wlr_drm_format **ptr = format_set_get_ref(set, format); if (ptr) {