From 0978a702d7eda51acd340b53984d844f17a45e39 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Wed, 11 Aug 2021 17:42:31 +0200 Subject: [PATCH] surface: ensure buffer is reset to NULL in surface_state_move When surface_state_move processes a NULL commit, make sure to reset state->buffer to NULL instead of leaving behind an old wlr_buffer. --- types/wlr_surface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/wlr_surface.c b/types/wlr_surface.c index 2058e21a..f8c1dbd5 100644 --- a/types/wlr_surface.c +++ b/types/wlr_surface.c @@ -284,8 +284,9 @@ static void surface_state_move(struct wlr_surface_state *state, surface_state_set_buffer(state, next->buffer_resource); surface_state_reset_buffer(next); + wlr_buffer_unlock(state->buffer); + state->buffer = NULL; if (next->buffer) { - wlr_buffer_unlock(state->buffer); state->buffer = wlr_buffer_lock(next->buffer); } wlr_buffer_unlock(next->buffer);