From d0bb7df6303cbe919f5d6d456cd4a8d46904b115 Mon Sep 17 00:00:00 2001 From: Manuel Stoeckl Date: Thu, 18 Nov 2021 17:55:56 -0500 Subject: [PATCH] output: remove XRGB8888 cursor fallback format All graphics drivers supporting cursor planes support ARGB8888, the default cursor format, so this fallback is almost certainly unused. Essentially all cursor themes use alpha transparency to make it clearer where relative to the screen content the cursor hotspot is. It is better to fall back to a slightly slower software cursor than it is to fall back to the opaque square that is a hardware cursor without an alpha channel. --- types/output/cursor.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/types/output/cursor.c b/types/output/cursor.c index e1414201..8fa2cf01 100644 --- a/types/output/cursor.c +++ b/types/output/cursor.c @@ -206,13 +206,7 @@ static struct wlr_drm_format *output_pick_cursor_format(struct wlr_output *outpu } } - struct wlr_drm_format *format = output_pick_format(output, display_formats, - DRM_FORMAT_ARGB8888); - if (format == NULL) { - format = output_pick_format(output, display_formats, - DRM_FORMAT_XRGB8888); - } - return format; + return output_pick_format(output, display_formats, DRM_FORMAT_ARGB8888); } static struct wlr_buffer *render_cursor_buffer(struct wlr_output_cursor *cursor) {