From 710b9b25a1f9e5b8c7d554a5ea012381fdd551dc Mon Sep 17 00:00:00 2001
From: curben <2809763-curben@users.noreply.gitlab.com>
Date: Fri, 30 Aug 2019 05:43:20 +0100
Subject: [PATCH] fix(head): meta generator tag should be after
- so that browser can parse <title> asap
---
scripts/cloudinary.js | 33 +++++++++++++-------------
themes/typing/layout/_partial/head.ejs | 2 +-
2 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/scripts/cloudinary.js b/scripts/cloudinary.js
index aa291b1..5728945 100644
--- a/scripts/cloudinary.js
+++ b/scripts/cloudinary.js
@@ -10,7 +10,7 @@
hexo.extend.tag.register('cloudinary', (args) => {
const user = 'curben'
- let fileName = args[0]
+ const fileName = args[0]
const alt = args[1] || ''
let modern = ''
let legacy = ''
@@ -26,37 +26,36 @@ hexo.extend.tag.register('cloudinary', (args) => {
legacy = fileName
}
- fileName += '?auto_format=false'
- modern += '?auto_format=false'
- legacy += '?auto_format=false'
+ const modernLink = link + '/' + modern + '?auto_format=false'
+ const legacyLink = link + '/' + legacy + '?auto_format=false'
const img = `<img
- srcset="${link}/${legacy}&w=320 320w,
- ${link}/${legacy}&w=468 468w,
- ${link}/${legacy}&w=768 768w,
- ${link}/${legacy} 800w"
+ srcset="${legacyLink}&w=320 320w,
+ ${legacyLink}&w=468 468w,
+ ${legacyLink}&w=768 768w,
+ ${legacyLink} 800w"
sizes="(max-width: 320px) 320px,
(max-width: 468px) 468px,
(max-width: 768px) 768px,
800px"
- src="${link}/${legacy}"
+ src="${legacyLink}"
alt="${alt}" loading="lazy">`
if (fileName.endsWith('.png') || fileName.endsWith('.webp')) {
- return `<a href="${link}/${fileName}">
- <picture><noscript>
+ return `<a href="${legacyLink}">
+ <picture>
<source type="image/webp"
- srcset="${link}/${modern}&w=320 320w,
- ${link}/${modern}&w=468 468w,
- ${link}/${modern}&w=768 768w,
- ${link}/${modern} 800w"
+ srcset="${modernLink}&w=320 320w,
+ ${modernLink}&w=468 468w,
+ ${modernLink}&w=768 768w,
+ ${modernLink} 800w"
sizes="(max-width: 320px) 320px,
(max-width: 468px) 468px,
(max-width: 768px) 768px,
800px">
${img}
- </noscript></picture></a>`
+ </picture></a>`
} else {
- return `<a href="${link}/${fileName}"><noscript>${img}</noscript></a>`
+ return `<a href="${legacyLink}">${img}</a>`
}
})
diff --git a/themes/typing/layout/_partial/head.ejs b/themes/typing/layout/_partial/head.ejs
index abc4236..2047e3d 100644
--- a/themes/typing/layout/_partial/head.ejs
+++ b/themes/typing/layout/_partial/head.ejs
@@ -1,6 +1,5 @@
<head>
<meta charset="utf-8">
- <%- metaGenerator() %>
<%
let title = page.title
@@ -23,6 +22,7 @@
%>
<title><% if (title) { %><%= title %> | <% } %><%= config.title %>
+ <%- metaGenerator() %>
<%/* Add Open Graph meta tags for easier sharing on social networking sites */%>
<%/* Modified from original source for compatibility with my blog */%>
<%- openGraph() %>