From 7ce52e381a16615ce40228f16f7f591f31ca0902 Mon Sep 17 00:00:00 2001 From: MDLeom <2809763-curben@users.noreply.gitlab.com> Date: Sun, 12 Apr 2020 10:18:12 +0100 Subject: [PATCH] fix(mobile-menu): ignore click if mobile menu is hidden --- themes/chameleon/source/js/chameleon.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/themes/chameleon/source/js/chameleon.js b/themes/chameleon/source/js/chameleon.js index af42a1d..95a4683 100644 --- a/themes/chameleon/source/js/chameleon.js +++ b/themes/chameleon/source/js/chameleon.js @@ -14,9 +14,11 @@ document.addEventListener('click', (evt) => { const mobileToggle = document.getElementById('mobile-menu-toggle') const isClickedOutside = !mobileNav.contains(evt.target) - // Exit if not in mobile view or menu button is clicked + // Exit if not in mobile view or menu button is clicked or menu is currently hidden // Menu button click triggers `menu-button` and `mobile-menu-toggle` - if (mainNavDisplay !== 'none' || evt.target.id === 'menu-button' || evt.target.id === 'mobile-menu-toggle') return + if (mainNavDisplay !== 'none' || + evt.target.id === 'menu-button' || evt.target.id === 'mobile-menu-toggle' || + mobileToggle.checked === false) return if (isClickedOutside) { mobileToggle.checked = false