curben
/
cloudflared-mirror
mirror of https://github.com/cloudflare/cloudflared.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

TUN-8904: Rename Connect Response Flow Rate Limited metadata 

## Summary

This commit renames the public variable that identifies the metadata key and value for the ConnectResponse structure when the flow was rate limited.

 Closes TUN-8904
This commit is contained in:
João "Pisco" Fernandes 2025-01-22 07:23:46 -08:00
parent 18eecaf151
commit 0f1bfe99ce
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
connection/quic_connection.go
View File

@ -186,7 +186,7 @@ func (q *quicConnection) handleDataStream(ctx context.Context, stream *rpcquic.R
var metadata []pogs.Metadata var metadata []pogs.Metadata
// Check the type of error that was throw and add metadata that will help identify it on OTD. // Check the type of error that was throw and add metadata that will help identify it on OTD.
if errors.Is(err, cfdflow.ErrTooManyActiveFlows) { if errors.Is(err, cfdflow.ErrTooManyActiveFlows) {
metadata = append(metadata, pogs.ErrorFlowConnectRateLimitedKey) metadata = append(metadata, pogs.ErrorFlowConnectRateLimitedMetadata)
} }
if writeRespErr := stream.WriteConnectResponseData(err, metadata...); writeRespErr != nil { if writeRespErr := stream.WriteConnectResponseData(err, metadata...); writeRespErr != nil {

2
connection/quic_connection_test.go
View File

@ -639,7 +639,7 @@ func TestTCPProxy_FlowRateLimited(t *testing.T) {
// Got Rate Limited // Got Rate Limited
assert.NotEmpty(t, response.Error) assert.NotEmpty(t, response.Error)
assert.Contains(t, response.Metadata, pogs.ErrorFlowConnectRateLimitedKey) assert.Contains(t, response.Metadata, pogs.ErrorFlowConnectRateLimitedMetadata)
}() }()
tunnelConn, _ := testTunnelConnection(t, netip.MustParseAddrPort(udpListener.LocalAddr().String()), uint8(0)) tunnelConn, _ := testTunnelConnection(t, netip.MustParseAddrPort(udpListener.LocalAddr().String()), uint8(0))

4
tunnelrpc/pogs/quic_metadata_protocol.go
View File

@ -19,8 +19,8 @@ const (
) )
var ( var (
// ErrorFlowConnectRateLimitedKey is the Metadata entry that allows to know if a request was rate limited on connect. // ErrorFlowConnectRateLimitedMetadata is the Metadata entry that allows to know if a request was rate limited on connect.
ErrorFlowConnectRateLimitedKey = Metadata{Key: "FlowConnectRateLimited", Val: "true"} ErrorFlowConnectRateLimitedMetadata = Metadata{Key: "FlowConnectRateLimited", Val: "true"}
) )
func (c ConnectionType) String() string { func (c ConnectionType) String() string {