From 22cd8ceb8cf279afc1c412ae7f98308ffcfdd298 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Oliveirinha?= Date: Mon, 21 Feb 2022 14:51:43 +0000 Subject: [PATCH] TUN-5682: Remove name field from credentials --- cmd/cloudflared/tunnel/quick_tunnel.go | 1 - cmd/cloudflared/tunnel/subcommand_context.go | 3 +-- cmd/cloudflared/tunnel/subcommand_context_test.go | 2 -- connection/connection.go | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/cmd/cloudflared/tunnel/quick_tunnel.go b/cmd/cloudflared/tunnel/quick_tunnel.go index e514b4ad..0dd7747b 100644 --- a/cmd/cloudflared/tunnel/quick_tunnel.go +++ b/cmd/cloudflared/tunnel/quick_tunnel.go @@ -55,7 +55,6 @@ func RunQuickTunnel(sc *subcommandContext) error { AccountTag: data.Result.AccountTag, TunnelSecret: data.Result.Secret, TunnelID: tunnelID, - TunnelName: data.Result.Name, } url := data.Result.Hostname diff --git a/cmd/cloudflared/tunnel/subcommand_context.go b/cmd/cloudflared/tunnel/subcommand_context.go index 03d8c796..97784d0d 100644 --- a/cmd/cloudflared/tunnel/subcommand_context.go +++ b/cmd/cloudflared/tunnel/subcommand_context.go @@ -185,7 +185,6 @@ func (sc *subcommandContext) create(name string, credentialsFilePath string, sec AccountTag: credential.cert.AccountID, TunnelSecret: tunnelSecret, TunnelID: tunnel.ID, - TunnelName: name, } usedCertPath := false if credentialsFilePath == "" { @@ -370,7 +369,7 @@ func (sc *subcommandContext) findID(input string) (uuid.UUID, error) { // Look up name in the credentials file. credFinder := newStaticPath(sc.c.String(CredFileFlag), sc.fs) if credentials, err := sc.readTunnelCredentials(credFinder); err == nil { - if credentials.TunnelID != uuid.Nil && input == credentials.TunnelName { + if credentials.TunnelID != uuid.Nil { return credentials.TunnelID, nil } } diff --git a/cmd/cloudflared/tunnel/subcommand_context_test.go b/cmd/cloudflared/tunnel/subcommand_context_test.go index b9a7108e..31d04b05 100644 --- a/cmd/cloudflared/tunnel/subcommand_context_test.go +++ b/cmd/cloudflared/tunnel/subcommand_context_test.go @@ -116,7 +116,6 @@ func Test_subcommandContext_findCredentials(t *testing.T) { AccountTag: accountTag, TunnelID: tunnelID, TunnelSecret: secret, - TunnelName: name, }, }, { @@ -161,7 +160,6 @@ func Test_subcommandContext_findCredentials(t *testing.T) { AccountTag: accountTag, TunnelID: tunnelID, TunnelSecret: secret, - TunnelName: name, }, }, } diff --git a/connection/connection.go b/connection/connection.go index 007011d0..b3a0804c 100644 --- a/connection/connection.go +++ b/connection/connection.go @@ -41,7 +41,6 @@ type Credentials struct { AccountTag string TunnelSecret []byte TunnelID uuid.UUID - TunnelName string } func (c *Credentials) Auth() pogs.TunnelAuth {