From 27c697774687031f580a093deac19c14644e3443 Mon Sep 17 00:00:00 2001 From: Austin Cherry Date: Fri, 1 Feb 2019 16:56:33 -0600 Subject: [PATCH] AUTH-1403: Print the paths in the ssh-config instructions --- cmd/cloudflared/access/cmd.go | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/cmd/cloudflared/access/cmd.go b/cmd/cloudflared/access/cmd.go index 74b9fedb..7ca30a6b 100644 --- a/cmd/cloudflared/access/cmd.go +++ b/cmd/cloudflared/access/cmd.go @@ -5,6 +5,7 @@ import ( "fmt" "net/url" "os" + "strings" "github.com/cloudflare/cloudflared/cmd/cloudflared/shell" "github.com/cloudflare/cloudflared/cmd/cloudflared/token" @@ -191,10 +192,9 @@ func generateToken(c *cli.Context) error { // sshConfig prints an example SSH config to stdout func sshConfig(c *cli.Context) error { - _, err := os.Stdout.Write([]byte(`Add this configuration block to your $HOME/.ssh/config - Host - ProxyCommand cloudflared access ssh --hostname %h` + "\n")) - return err + outputMessage := "Add this configuration block to your %s/.ssh/config:\n\nHost [your hostname]\n\tProxyCommand %s access ssh --hostname %%h\n" + logger.Printf(outputMessage, os.Getenv("HOME"), cloudflaredPath()) + return nil } // getAppURL will pull the appURL needed for fetching a user's Access token @@ -248,3 +248,23 @@ func processURL(s string) (*url.URL, error) { return u, nil } + +// cloudflaredPath pulls the full path of cloudflared on disk +func cloudflaredPath() string { + for _, p := range strings.Split(os.Getenv("PATH"), ":") { + path := fmt.Sprintf("%s/%s", p, "cloudflared") + if isFileThere(path) { + return path + } + } + return "cloudflared" +} + +// isFileThere will check for the presence of candidate path +func isFileThere(candidate string) bool { + fi, err := os.Stat(candidate) + if err != nil || fi.IsDir() || !fi.Mode().IsRegular() { + return false + } + return true +}