TUN-6414: Remove go-sumtype from cloudflared build process

This PR removes go-sumtype from cloudflared's build processes.

The value we see from analysing exhaustive match patterns in go is minimal (we can do this in code reviews) compared to using a tool that is unmaintained and (now broken) in Go 1.18.

We'd already been using the patched version here: https://github.com/sudarshan-reddy/go-sumtype because the original is broken for go tools > 1.16
This commit is contained in:
Sudarsan Reddy 2022-06-17 09:23:44 +01:00
parent fa6bcdad04
commit 337591b2bb
3 changed files with 0 additions and 8 deletions

View File

@ -12,8 +12,6 @@ jobs:
uses: actions/setup-go@v2 uses: actions/setup-go@v2
with: with:
go-version: ${{ matrix.go-version }} go-version: ${{ matrix.go-version }}
- name: Install go-sumtype
run: go get github.com/sudarshan-reddy/go-sumtype
- name: Checkout code - name: Checkout code
uses: actions/checkout@v2 uses: actions/checkout@v2
- name: Test - name: Test

View File

@ -293,11 +293,6 @@ quic-deps:
.PHONY: vet .PHONY: vet
vet: vet:
go vet -mod=vendor ./... go vet -mod=vendor ./...
# go get github.com/sudarshan-reddy/go-sumtype (don't do this in build directory or this will cause vendor issues)
# Note: If you have github.com/BurntSushi/go-sumtype then you might have to use the repo above instead
# for now because it uses an older version of golang.org/x/tools.
which go-sumtype
go-sumtype $$(go list -mod=vendor ./...)
.PHONY: goimports .PHONY: goimports
goimports: goimports:

View File

@ -153,7 +153,6 @@ stretch: &stretch
- gotest-to-teamcity - gotest-to-teamcity
pre-cache: &test_pre_cache pre-cache: &test_pre_cache
- go get golang.org/x/tools/cmd/goimports - go get golang.org/x/tools/cmd/goimports
- go get github.com/sudarshan-reddy/go-sumtype@v0.0.0-20210827105221-82eca7e5abb1
post-cache: post-cache:
- export GOOS=linux - export GOOS=linux
- export GOARCH=amd64 - export GOARCH=amd64