diff --git a/cmd/cloudflared/tunnel/cmd.go b/cmd/cloudflared/tunnel/cmd.go index 6bbcfa41..1a975bec 100644 --- a/cmd/cloudflared/tunnel/cmd.go +++ b/cmd/cloudflared/tunnel/cmd.go @@ -191,9 +191,9 @@ func StartServer(c *cli.Context, version string, shutdownC, graceShutdownC chan return errors.Wrap(err, "Error configuring logger") } - protoLogger, err := configProtoLogger(c) + transportLogger, err := configTransportLogger(c) if err != nil { - return errors.Wrap(err, "Error configuring protocol logger") + return errors.Wrap(err, "Error configuring transport logger") } if c.IsSet("trace-output") { @@ -224,7 +224,7 @@ func StartServer(c *cli.Context, version string, shutdownC, graceShutdownC chan } if c.String("logfile") != "" { - if err := initLogFile(c, logger, protoLogger); err != nil { + if err := initLogFile(c, logger, transportLogger); err != nil { logger.Error(err) } } @@ -318,7 +318,7 @@ func StartServer(c *cli.Context, version string, shutdownC, graceShutdownC chan c.Set("url", "http://"+listener.Addr().String()) } - tunnelConfig, err := prepareTunnelConfig(c, buildInfo, version, logger, protoLogger) + tunnelConfig, err := prepareTunnelConfig(c, buildInfo, version, logger, transportLogger) if err != nil { return err } @@ -539,10 +539,11 @@ func tunnelFlags(shouldHide bool) []cli.Flag { Hidden: shouldHide, }), altsrc.NewStringFlag(&cli.StringFlag{ - Name: "proto-loglevel", + Name: "transport-loglevel", + Aliases: []string{"proto-loglevel"}, // This flag used to be called proto-loglevel Value: "warn", - Usage: "Protocol logging level {panic, fatal, error, warn, info, debug}", - EnvVars: []string{"TUNNEL_PROTO_LOGLEVEL"}, + Usage: "Transport logging level(previously called protocol logging level) {panic, fatal, error, warn, info, debug}", + EnvVars: []string{"TUNNEL_PROTO_LOGLEVEL", "TUNNEL_TRANSPORT_LOGLEVEL"}, Hidden: shouldHide, }), altsrc.NewUintFlag(&cli.UintFlag{ diff --git a/cmd/cloudflared/tunnel/configuration.go b/cmd/cloudflared/tunnel/configuration.go index fca4993f..17c15cb7 100644 --- a/cmd/cloudflared/tunnel/configuration.go +++ b/cmd/cloudflared/tunnel/configuration.go @@ -136,7 +136,7 @@ If you don't have a certificate signed by Cloudflare, run the command: return originCert, nil } -func prepareTunnelConfig(c *cli.Context, buildInfo *origin.BuildInfo, version string, logger, protoLogger *logrus.Logger) (*origin.TunnelConfig, error) { +func prepareTunnelConfig(c *cli.Context, buildInfo *origin.BuildInfo, version string, logger, transportLogger *logrus.Logger) (*origin.TunnelConfig, error) { hostname, err := validation.ValidateHostname(c.String("hostname")) if err != nil { logger.WithError(err).Error("Invalid hostname") @@ -223,7 +223,7 @@ func prepareTunnelConfig(c *cli.Context, buildInfo *origin.BuildInfo, version st HTTPTransport: httpTransport, Metrics: tunnelMetrics, MetricsUpdateFreq: c.Duration("metrics-update-freq"), - ProtocolLogger: protoLogger, + TransportLogger: transportLogger, Logger: logger, IsAutoupdated: c.Bool("is-autoupdated"), GracePeriod: c.Duration("grace-period"), diff --git a/cmd/cloudflared/tunnel/logger.go b/cmd/cloudflared/tunnel/logger.go index 078632ea..cb28af97 100644 --- a/cmd/cloudflared/tunnel/logger.go +++ b/cmd/cloudflared/tunnel/logger.go @@ -25,15 +25,15 @@ func configMainLogger(c *cli.Context) error { return nil } -func configProtoLogger(c *cli.Context) (*logrus.Logger, error) { - protoLogLevel, err := logrus.ParseLevel(c.String("proto-loglevel")) +func configTransportLogger(c *cli.Context) (*logrus.Logger, error) { + transportLogLevel, err := logrus.ParseLevel(c.String("transport-loglevel")) if err != nil { - logger.WithError(err).Fatal("Unknown protocol logging level specified") - return nil, errors.Wrap(err, "Unknown protocol logging level specified") + logger.WithError(err).Fatal("Unknown transport logging level specified") + return nil, errors.Wrap(err, "Unknown transport logging level specified") } - protoLogger := logrus.New() - protoLogger.Level = protoLogLevel - return protoLogger, nil + transportLogger := logrus.New() + transportLogger.Level = transportLogLevel + return transportLogger, nil } func initLogFile(c *cli.Context, loggers ...*logrus.Logger) error { diff --git a/origin/tunnel.go b/origin/tunnel.go index 184be561..67cc30ad 100644 --- a/origin/tunnel.go +++ b/origin/tunnel.go @@ -55,7 +55,7 @@ type TunnelConfig struct { HTTPTransport http.RoundTripper Metrics *TunnelMetrics MetricsUpdateFreq time.Duration - ProtocolLogger *log.Logger + TransportLogger *log.Logger Logger *log.Logger IsAutoupdated bool GracePeriod time.Duration @@ -236,7 +236,7 @@ func ServeTunnel( select { case <-serveCtx.Done(): // UnregisterTunnel blocks until the RPC call returns - err := UnregisterTunnel(handler.muxer, config.GracePeriod, config.Logger) + err := UnregisterTunnel(handler.muxer, config.GracePeriod, config.TransportLogger) handler.muxer.Shutdown() return err case <-updateMetricsTickC: @@ -303,7 +303,7 @@ func RegisterTunnel( connectionID uint8, originLocalIP string, ) error { - config.Logger.Debug("initiating RPC stream to register") + config.TransportLogger.Debug("initiating RPC stream to register") stream, err := muxer.OpenStream([]h2mux.Header{ {Name: ":method", Value: "RPC"}, {Name: ":scheme", Value: "capnp"}, @@ -318,8 +318,8 @@ func RegisterTunnel( return clientRegisterTunnelError{cause: err} } conn := rpc.NewConn( - tunnelrpc.NewTransportLogger(config.Logger.WithField("subsystem", "rpc-register"), rpc.StreamTransport(stream)), - tunnelrpc.ConnLog(config.Logger.WithField("subsystem", "rpc-transport")), + tunnelrpc.NewTransportLogger(config.TransportLogger.WithField("subsystem", "rpc-register"), rpc.StreamTransport(stream)), + tunnelrpc.ConnLog(config.TransportLogger.WithField("subsystem", "rpc-transport")), ) defer conn.Close() ts := tunnelpogs.TunnelServer_PogsClient{Client: conn.Bootstrap(ctx)} @@ -531,7 +531,7 @@ func NewTunnelHandler(ctx context.Context, IsClient: true, HeartbeatInterval: config.HeartbeatInterval, MaxHeartbeats: config.MaxHeartbeats, - Logger: config.ProtocolLogger.WithFields(log.Fields{}), + Logger: config.TransportLogger.WithFields(log.Fields{}), CompressionQuality: h2mux.CompressionSetting(config.CompressionQuality), }) if err != nil {