curben
/
cloudflared-mirror
mirror of https://github.com/cloudflare/cloudflared.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

TUN-7000: Reduce metric cardinality of closedConnections metric by removing error as tag

This commit is contained in:
João Oliveirinha 2022-12-07 11:04:32 +00:00
parent 45e8eb7275
commit 7ef9bb89d3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
quic/metrics.go
View File

@ -15,7 +15,7 @@ var (
clientConnLabels = []string{"conn_index"} clientConnLabels = []string{"conn_index"}
clientMetrics = struct { clientMetrics = struct {
totalConnections prometheus.Counter totalConnections prometheus.Counter
closedConnections *prometheus.CounterVec closedConnections prometheus.Counter
sentPackets *prometheus.CounterVec sentPackets *prometheus.CounterVec
sentBytes *prometheus.CounterVec sentBytes *prometheus.CounterVec
receivePackets *prometheus.CounterVec receivePackets *prometheus.CounterVec
@ -30,9 +30,8 @@ var (
totalConnections: prometheus.NewCounter( totalConnections: prometheus.NewCounter(
totalConnectionsOpts(logging.PerspectiveClient), totalConnectionsOpts(logging.PerspectiveClient),
), ),
closedConnections: prometheus.NewCounterVec( closedConnections: prometheus.NewCounter(
closedConnectionsOpts(logging.PerspectiveClient), closedConnectionsOpts(logging.PerspectiveClient),
[]string{"error"},
), ),
sentPackets: prometheus.NewCounterVec( sentPackets: prometheus.NewCounterVec(
sentPacketsOpts(logging.PerspectiveClient), sentPacketsOpts(logging.PerspectiveClient),
@ -284,7 +283,7 @@ func (cc *clientCollector) startedConnection() {
} }
func (cc *clientCollector) closedConnection(err error) { func (cc *clientCollector) closedConnection(err error) {
clientMetrics.closedConnections.WithLabelValues(err.Error()).Inc() clientMetrics.closedConnections.Inc()
} }
func (cc *clientCollector) sentPackets(size logging.ByteCount) { func (cc *clientCollector) sentPackets(size logging.ByteCount) {