diff --git a/RELEASE_NOTES b/RELEASE_NOTES index 52fdc8a6..c3f195e3 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -112,7 +112,7 @@ 2019.9.0 - 2019-09-05 TUN-2279: Revert path encoding fix - 2019-08-30 AUTH-2021 - check error for failing tests -- 2019-08-29 AUTH-2030: Support both authorized_key and short lived cert authentication simultaniously without specifiying at start time +- 2019-08-29 AUTH-2030: Support both authorized_key and short lived cert authentication simultaneously without specifying at start time - 2019-08-29 AUTH-2026: Adds support for non-pty sessions and inline command exec - 2019-08-26 AUTH-1943: Adds session logging - 2019-08-26 TUN-2162: Decomplect OpenStream to allow finer-grained timeouts diff --git a/cmd/cloudflared/config/configuration.go b/cmd/cloudflared/config/configuration.go index cb497dc2..c336438f 100644 --- a/cmd/cloudflared/config/configuration.go +++ b/cmd/cloudflared/config/configuration.go @@ -67,7 +67,7 @@ func FindDefaultConfigPath() string { // i.e. it fails if a user specifies both --url and --unix-socket func ValidateUnixSocket(c *cli.Context) (string, error) { if c.IsSet("unix-socket") && (c.IsSet("url") || c.NArg() > 0) { - return "", errors.New("--unix-socket must be used exclusivly.") + return "", errors.New("--unix-socket must be used exclusively.") } return c.String("unix-socket"), nil } diff --git a/cmd/cloudflared/tunnel/signal.go b/cmd/cloudflared/tunnel/signal.go index afc26ccf..8cafa1c8 100644 --- a/cmd/cloudflared/tunnel/signal.go +++ b/cmd/cloudflared/tunnel/signal.go @@ -28,7 +28,7 @@ func waitForSignal(errC chan error, shutdownC chan struct{}) error { // waitForSignalWithGraceShutdown notifies all routines to shutdown immediately // by closing the shutdownC when one of the routines in main exits. -// When this process recieves SIGTERM/SIGINT, it closes the graceShutdownC to +// When this process receives SIGTERM/SIGINT, it closes the graceShutdownC to // notify certain routines to start graceful shutdown. When grace period is over, // or when some routine exits, it notifies the rest of the routines to shutdown // immediately by closing shutdownC. diff --git a/dbconnect/cmd.go b/dbconnect/cmd.go index e24fec4d..0595d385 100644 --- a/dbconnect/cmd.go +++ b/dbconnect/cmd.go @@ -149,7 +149,7 @@ func CmdAction(c *cli.Context) error { } }() - // Block until the the Proxy is online, retreive its address, and change the url to point to it. + // Block until the the Proxy is online, retrieve its address, and change the url to point to it. // This is effectively "handing over" control to the tunnel package so it can run the tunnel daemon. c.Set("url", "https://"+(<-listenerC).Addr().String()) diff --git a/dbconnect/proxy.go b/dbconnect/proxy.go index 2a1a53ad..4a445101 100644 --- a/dbconnect/proxy.go +++ b/dbconnect/proxy.go @@ -98,7 +98,7 @@ func (proxy *Proxy) IsAllowed(r *http.Request, verbose ...bool) bool { // Start the Proxy at a given address and notify the listener channel when the server is online. func (proxy *Proxy) Start(ctx context.Context, addr string, listenerC chan<- net.Listener) error { - // STOR-611: use a seperate listener and consider web socket support. + // STOR-611: use a separate listener and consider web socket support. httpListener, err := hello.CreateTLSListener(addr) if err != nil { return errors.Wrapf(err, "could not create listener at %s", addr) @@ -217,7 +217,7 @@ func (proxy *Proxy) httpSubmit() http.HandlerFunc { func (proxy *Proxy) httpRespond(w http.ResponseWriter, r *http.Request, status int, message string) { w.WriteHeader(status) - // Only expose the message detail of the reponse if the request is not HEAD + // Only expose the message detail of the response if the request is not HEAD // and the user is authenticated. For example, this prevents an unauthenticated // failed health check from accidentally leaking sensitive information about the Client. if r.Method != http.MethodHead && proxy.IsAllowed(r) { diff --git a/dbconnect/sql.go b/dbconnect/sql.go index 2bd5b56f..83070aa5 100644 --- a/dbconnect/sql.go +++ b/dbconnect/sql.go @@ -278,10 +278,10 @@ func sqlRows(rows *sql.Rows) ([]map[string]interface{}, error) { func sqlValue(val interface{}, col *sql.ColumnType) interface{} { bytes, ok := val.([]byte) if ok { - // Opportunistically check for embeded JSON and convert it to a first-class object. - var embeded interface{} - if json.Unmarshal(bytes, &embeded) == nil { - return embeded + // Opportunistically check for embedded JSON and convert it to a first-class object. + var embedded interface{} + if json.Unmarshal(bytes, &embedded) == nil { + return embedded } // STOR-604: investigate a way to coerce PostgreSQL arrays '{a, b, ...}' into JSON. diff --git a/h2mux/h2_dictionaries.go b/h2mux/h2_dictionaries.go index bf92d58d..3d0f4c5f 100644 --- a/h2mux/h2_dictionaries.go +++ b/h2mux/h2_dictionaries.go @@ -468,7 +468,7 @@ func assignDictToStream(s *MuxedStream, p []byte) bool { } } else { // Use the overflow dictionary as last resort - // If slots are availabe generate new dictioanries for path and content-type + // If slots are available generate new dictionaries for path and content-type useID, _ = h2d.getGenericDictID() pathID, pathFound = h2d.getNextDictID() if pathFound { diff --git a/h2mux/h2mux.go b/h2mux/h2mux.go index 70da0447..eb234c98 100644 --- a/h2mux/h2mux.go +++ b/h2mux/h2mux.go @@ -273,7 +273,7 @@ func (m *Muxer) readPeerSettings(magic uint32) error { m.compressionQuality = compressionPresets[CompressionNone] return nil } - // Values used for compression are the mimimum between the two peers + // Values used for compression are the minimum between the two peers if sz < m.compressionQuality.dictSize { m.compressionQuality.dictSize = sz } diff --git a/originservice/originservice_test.go b/originservice/originservice_test.go index 2a1c0a3d..f914f10d 100644 --- a/originservice/originservice_test.go +++ b/originservice/originservice_test.go @@ -39,7 +39,7 @@ func TestIsEventStream(t *testing.T) { // Content-Type and text/event-stream are case-insensitive. text/event-stream can be followed by OWS parameter resp: &http.Response{ Header: http.Header{ - "content-type": []string{"appication/json", "text/html", "Text/event-stream;charset=utf-8"}, + "content-type": []string{"application/json", "text/html", "Text/event-stream;charset=utf-8"}, }, }, isEventStream: true, diff --git a/tunnelrpc/tunnelrpc.capnp b/tunnelrpc/tunnelrpc.capnp index 839fc0e5..70ddccf6 100644 --- a/tunnelrpc/tunnelrpc.capnp +++ b/tunnelrpc/tunnelrpc.capnp @@ -100,7 +100,7 @@ struct ClientConfig { # supervisorConfig is configuration for supervisor, the component that manages connection manager, # autoupdater and metrics server supervisorConfig @1 :SupervisorConfig; - # edgeConnectionConfig is configuration for connection manager, the componenet that manages connections with the edge + # edgeConnectionConfig is the configuration for the connection manager, the component that manages connections with the edge edgeConnectionConfig @2 :EdgeConnectionConfig; # Configuration for cloudflared to run as a DNS-over-HTTPS proxy. # cloudflared CLI option: `proxy-dns` diff --git a/validation/validation.go b/validation/validation.go index 97233864..b0563d49 100644 --- a/validation/validation.go +++ b/validation/validation.go @@ -74,7 +74,7 @@ func ValidateUrl(originUrl string) (string, error) { if net.ParseIP(originUrl) != nil { return validateIP("", originUrl, "") } else if strings.HasPrefix(originUrl, "[") && strings.HasSuffix(originUrl, "]") { - // ParseIP doesn't recoginze [::1] + // ParseIP doesn't recognize [::1] return validateIP("", originUrl[1:len(originUrl)-1], "") }