curben
/
cloudflared-mirror
mirror of https://github.com/cloudflare/cloudflared.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

bug(cloudflared): nil pointer deference on h2DictWriter Close() (#154) 

Unlike other h2DictWriter methods, the Close() method does check whether
w.comp is nil.

This PR adds a check for non nil compressor before attempting to close

Bug: #141
This commit is contained in:
Tim Bart 2019-12-03 04:29:40 -08:00 committed by Silver
parent 379cb16efe
commit 92736b2677
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
h2mux/h2_dictionaries.go
View File

@ -542,7 +542,10 @@ func (w *h2DictWriter) Write(p []byte) (n int, err error) {
} }
func (w *h2DictWriter) Close() error { func (w *h2DictWriter) Close() error {
if w.comp != nil {
return w.comp.Close() return w.comp.Close()
}
return nil
} }
// From http2/hpack // From http2/hpack