curben
/
cloudflared-mirror
mirror of https://github.com/cloudflare/cloudflared.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #672: Use "id" to check if the user exists

This commit is contained in:
Yonatan Romero 2022-09-20 10:06:18 +02:00
parent e4b4403d32
commit c11041344c
No known key found for this signature in database
GPG Key ID: 28EEA3C26EDA40BC
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/cloudflared/linux_service.go
View File

@ -273,7 +273,7 @@ func installSystemd(templateArgs *ServiceTemplateArgs, log *zerolog.Logger) erro
}
}
// Create the cloudflared user if it does not exist
if err := runCommand("grep", "-q", fmt.Sprintf("^%s:", cloudflaredUser), "/etc/passwd"); err != nil {
if err := runCommand("id", cloudflaredUser); err != nil {
if err := runCommand("useradd", "--system", "--no-create-home", "--home-dir=/nonexistent", "--shell=/usr/sbin/nologin", cloudflaredUser); err != nil {
log.Err(err).Msgf("useradd %s error", cloudflaredUser)
return err
@ -350,7 +350,7 @@ func uninstallSystemd(log *zerolog.Logger) error {
return err
}
// Delete the cloudflared user if it exists
if err := runCommand("grep", "-q", fmt.Sprintf("^%s:", cloudflaredUser), "/etc/passwd"); err == nil {
if err := runCommand("id", cloudflaredUser); err == nil {
if err := runCommand("userdel", cloudflaredUser); err != nil {
log.Err(err).Msgf("userdel %s error", cloudflaredUser)
return err