TUN-7003: Tempoarily disable erroneous notarize-app
This PR temporarily disables the xcrun notarize-app feature since this is soemthing we've historically had broken. However, what changed now is we set -e for the mac os scripts. We'll need to remove this to unblock mac builds. We could spend time as part of https://jira.cfdata.org/browse/TUN-5789 to look into this.
This commit is contained in:
		
							parent
							
								
									b8b35d99fa
								
							
						
					
					
						commit
						c13b6df0a7
					
				| 
						 | 
					@ -143,12 +143,7 @@ if [[ ! -z "$CODE_SIGN_NAME" ]]; then
 | 
				
			||||||
  codesign -s "${CODE_SIGN_NAME}" -f -v --timestamp --options runtime ${BINARY_NAME}
 | 
					  codesign -s "${CODE_SIGN_NAME}" -f -v --timestamp --options runtime ${BINARY_NAME}
 | 
				
			||||||
  
 | 
					  
 | 
				
			||||||
 # notarize the binary
 | 
					 # notarize the binary
 | 
				
			||||||
  if [[ ! -z "$CFD_NOTE_PASSWORD" ]]; then
 | 
					 # TODO: https://jira.cfdata.org/browse/TUN-5789
 | 
				
			||||||
    zip "${BINARY_NAME}.zip" ${BINARY_NAME} 
 | 
					 | 
				
			||||||
    xcrun altool --notarize-app -f "${BINARY_NAME}.zip" -t osx -u ${CFD_NOTE_USERNAME} -p ${CFD_NOTE_PASSWORD} --primary-bundle-id ${BUNDLE_ID}
 | 
					 | 
				
			||||||
  fi
 | 
					 | 
				
			||||||
fi
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
# creating build directory
 | 
					# creating build directory
 | 
				
			||||||
rm -rf $TARGET_DIRECTORY
 | 
					rm -rf $TARGET_DIRECTORY
 | 
				
			||||||
| 
						 | 
					@ -173,10 +168,7 @@ if [[ ! -z "$PKG_SIGN_NAME" ]]; then
 | 
				
			||||||
      ${PKGNAME}
 | 
					      ${PKGNAME}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
      # notarize the package
 | 
					      # notarize the package
 | 
				
			||||||
      if [[ ! -z "$CFD_NOTE_PASSWORD" ]]; then
 | 
					      # TODO: https://jira.cfdata.org/browse/TUN-5789
 | 
				
			||||||
        xcrun altool --notarize-app -f ${PKGNAME} -t osx -u ${CFD_NOTE_USERNAME} -p ${CFD_NOTE_PASSWORD} --primary-bundle-id ${BUNDLE_ID}
 | 
					 | 
				
			||||||
        xcrun stapler staple ${PKGNAME}
 | 
					 | 
				
			||||||
      fi
 | 
					 | 
				
			||||||
else
 | 
					else
 | 
				
			||||||
    pkgbuild --identifier com.cloudflare.${PRODUCT} \
 | 
					    pkgbuild --identifier com.cloudflare.${PRODUCT} \
 | 
				
			||||||
      --version ${VERSION} \
 | 
					      --version ${VERSION} \
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in New Issue