From fa2234d6391af607826c0f349d418e71c4792d23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Oliveirinha?= Date: Fri, 6 May 2022 18:47:03 +0100 Subject: [PATCH] TUN-6185: Fix tcpOverWSOriginService not using original scheme for String representation --- ingress/origin_service.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ingress/origin_service.go b/ingress/origin_service.go index 239b6e93..c96e4608 100644 --- a/ingress/origin_service.go +++ b/ingress/origin_service.go @@ -109,6 +109,7 @@ func (o rawTCPService) MarshalJSON() ([]byte, error) { // tcpOverWSService models TCP origins serving eyeballs connecting over websocket, such as // cloudflared access commands. type tcpOverWSService struct { + scheme string dest string isBastion bool streamHandler streamHandlerFunc @@ -130,7 +131,8 @@ func newTCPOverWSService(url *url.URL) *tcpOverWSService { addPortIfMissing(url, 7864) // just a random port since there isn't a default in this case } return &tcpOverWSService{ - dest: url.Host, + scheme: url.Scheme, + dest: url.Host, } } @@ -160,7 +162,12 @@ func (o *tcpOverWSService) String() string { if o.isBastion { return ServiceBastion } - return o.dest + + if o.scheme != "" { + return fmt.Sprintf("%s://%s", o.scheme, o.dest) + } else { + return o.dest + } } func (o *tcpOverWSService) start(log *zerolog.Logger, _ <-chan struct{}, cfg OriginRequestConfig) error {