blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

text-input: Don't reject enable requests when unfocused 

The prevoius implementation would always raise an error in the following sequence:

-> enter
-> leave
<- enable

The text-input type is not equipped to manage the validity of clents' requests, which should be handled in the compositor, as rootston does.
This commit is contained in:
Dorota Czaplejewicz 2018-10-17 15:34:41 +00:00
parent affc83ff82
commit 14c6ee894e
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
types/wlr_text_input_v3.c
View File

@ -175,11 +175,10 @@ static void text_input_commit(struct wl_client *client,
text_input->current_enabled = text_input->pending_enabled; text_input->current_enabled = text_input->pending_enabled;
text_input->current_serial++; text_input->current_serial++;
if (text_input->current_enabled && text_input->focused_surface == NULL) { if (text_input->focused_surface == NULL) {
wl_resource_post_error(text_input->resource, 0, "Text input was not" wlr_log(WLR_DEBUG, "Text input commit received without focus\n");
"entered, and cannot be enabled\n");
return;
} }
if (!old_enabled && text_input->current_enabled) { if (!old_enabled && text_input->current_enabled) {
wlr_signal_emit_safe(&text_input->events.enable, text_input); wlr_signal_emit_safe(&text_input->events.enable, text_input);
} else if (old_enabled && !text_input->current_enabled) { } else if (old_enabled && !text_input->current_enabled) {