blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

data-device: ignore accept for selection offers 

It doesn't make sense for clients to send "accept" requests to offers that
aren't drag-and-drop. I discussed with Daniel Stone to make it a protocol
error [1] but too many clients send it (e.g. GTK+). Let's just log it for now.

[1]: https://gitlab.freedesktop.org/wayland/wayland/merge_requests/11#note_149710
This commit is contained in:
Simon Ser 2019-04-19 20:35:15 +03:00 committed by Drew DeVault
parent d6615e0e84
commit 4207f05030
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
types/data_device/wlr_data_offer.c
View File

@ -82,6 +82,12 @@ static void data_offer_handle_accept(struct wl_client *client,
return; return;
} }
if (offer->type != WLR_DATA_OFFER_DRAG) {
wlr_log(WLR_DEBUG, "Ignoring wl_data_offer.accept request on a "
"non-drag-and-drop offer");
return;
}
wlr_data_source_accept(offer->source, serial, mime_type); wlr_data_source_accept(offer->source, serial, mime_type);
} }