blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix undefined behavior 

Without the casts the bytes accesses get converted to int. but int is
not guaranteed to be 4 bytes large. Even when it is 4 bytes large
`bytes[3] << 24` does not fit because int is signed.
This commit is contained in:
Valentin 2020-08-30 11:13:19 +02:00 committed by Simon Ser
parent 8b744412aa
commit 65abd4e92a
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
xcursor/xcursor.c
View File

@ -285,11 +285,12 @@ _XcursorReadUInt (XcursorFile *file, XcursorUInt *u)
return XcursorFalse; return XcursorFalse;
if ((*file->read) (file, bytes, 4) != 4) if ((*file->read) (file, bytes, 4) != 4)
return XcursorFalse; return XcursorFalse;
*u = ((bytes[0] << 0) |
(bytes[1] << 8) | *u = ((XcursorUInt)(bytes[0]) << 0) |
(bytes[2] << 16) | ((XcursorUInt)(bytes[1]) << 8) |
(bytes[3] << 24)); ((XcursorUInt)(bytes[2]) << 16) |
((XcursorUInt)(bytes[3]) << 24);
return XcursorTrue; return XcursorTrue;
} }