blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zwp_virtual-keyboard: fix mmap error handling 

If mmap fails, it will return MAP_FAILED not NULL. Since the error
handling was incorrectly checking for NULL, MAP_FAILED was being passed
to xkb_keymap_new_from_string, on mmap failure, causing a segfault.
This just fixes the error checking.
This commit is contained in:
Brian Ashworth 2019-05-30 23:38:48 -04:00 committed by Simon Ser
parent a5e32f652b
commit 6dfe238ff1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
types/wlr_virtual_keyboard_v1.c
View File

@ -51,7 +51,7 @@ static void virtual_keyboard_keymap(struct wl_client *client,
goto context_fail; goto context_fail;
} }
void *data = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); void *data = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0);
if (!data) { if (data == MAP_FAILED) {
goto fd_fail; goto fd_fail;
} }
struct xkb_keymap *keymap = xkb_keymap_new_from_string(context, data, struct xkb_keymap *keymap = xkb_keymap_new_from_string(context, data,