blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

surface: don't unref the current buffer on failure 

If wlr_buffer_create fails, keep the previous buffer.
This commit is contained in:
Simon Ser 2019-12-12 19:12:08 +01:00 committed by Drew DeVault
parent 96e8e9b098
commit 7fc58e704a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
types/wlr_surface.c
View File

@ -296,15 +296,13 @@ static void surface_apply_damage(struct wlr_surface *surface) {
} }
} }
wlr_buffer_unref(surface->buffer);
surface->buffer = NULL;
struct wlr_buffer *buffer = wlr_buffer_create(surface->renderer, resource); struct wlr_buffer *buffer = wlr_buffer_create(surface->renderer, resource);
if (buffer == NULL) { if (buffer == NULL) {
wlr_log(WLR_ERROR, "Failed to upload buffer"); wlr_log(WLR_ERROR, "Failed to upload buffer");
return; return;
} }
wlr_buffer_unref(surface->buffer);
surface->buffer = buffer; surface->buffer = buffer;
} }