blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

wlr_input_method_v2: Remove input method's resource from the list on destroy 

It's added to manager->input_methods list in manager_get_input_method, but
wasn't removed anywhere, leading to possible use-after-free in
wlr_input_method_manager_v2_destroy.
This commit is contained in:
Sebastian Krzyszkowiak 2019-08-07 15:25:26 +02:00 committed by Drew DeVault
parent 01f903874b
commit 913cac1835
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
types/wlr_input_method_v2.c
View File

@ -22,6 +22,7 @@ static struct wlr_input_method_v2 *input_method_from_resource(
static void input_method_destroy(struct wlr_input_method_v2 *input_method) { static void input_method_destroy(struct wlr_input_method_v2 *input_method) {
wlr_signal_emit_safe(&input_method->events.destroy, input_method); wlr_signal_emit_safe(&input_method->events.destroy, input_method);
wl_list_remove(wl_resource_get_link(input_method->resource));
wl_list_remove(&input_method->seat_destroy.link); wl_list_remove(&input_method->seat_destroy.link);
free(input_method->pending.commit_text); free(input_method->pending.commit_text);
free(input_method->pending.preedit.text); free(input_method->pending.preedit.text);