blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drm: fix uninitialized read 

get_drm_prop_blob does not set path_len if it returns NULL.  Check the
return value before path_len to avoid reading uninitialized memory.

(Granted, this doesn't change the logic at all, but it does make
Valgrind a bit happier.)
This commit is contained in:
Devin J. Pohly 2020-07-30 23:23:18 -05:00 committed by Simon Ser
parent 74f7be7287
commit aaf490d794
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/drm/drm.c
View File

@ -1398,7 +1398,7 @@ void scan_drm_connectors(struct wlr_drm_backend *drm) {
bool is_mst = false; bool is_mst = false;
char *path = get_drm_prop_blob(drm->fd, wlr_conn->id, char *path = get_drm_prop_blob(drm->fd, wlr_conn->id,
wlr_conn->props.path, &path_len); wlr_conn->props.path, &path_len);
if (path_len > 4 && path && strncmp(path, "mst:", 4) == 0) { if (path && path_len > 4 && strncmp(path, "mst:", 4) == 0) {
is_mst = true; is_mst = true;
} }
free(path); free(path);