blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

render/pixman: avoid sqrt() in render_quad without rotation 

When the matrix doesn't have a rotation, we can avoid a sqrt() call.

Tested with Sway's tabbed containers.
This commit is contained in:
Simon Ser 2021-05-19 11:00:30 +02:00 committed by Simon Zeni
parent 66e100ffbf
commit f73c04b801
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
render/pixman/renderer.c
View File

@ -230,10 +230,14 @@ static void pixman_render_quad_with_matrix(struct wlr_renderer *wlr_renderer,
memcpy(m, matrix, sizeof(m)); memcpy(m, matrix, sizeof(m));
// TODO get the width/height from the caller instead of extracting them // TODO get the width/height from the caller instead of extracting them
// TODO detect non rotation with matrix[1] == 0 and matrix[4] == 0 to avoid float width, height;
// doing the calculation if (matrix[1] == 0.0 && matrix[3] == 0.0) {
float width = sqrt(matrix[0] * matrix[0] + matrix[1] * matrix[1]); width = fabs(matrix[0]);
float height = sqrt(matrix[3] * matrix[3] + matrix[4] * matrix[4]); height = fabs(matrix[4]);
} else {
width = sqrt(matrix[0] * matrix[0] + matrix[1] * matrix[1]);
height = sqrt(matrix[3] * matrix[3] + matrix[4] * matrix[4]);
}
wlr_matrix_scale(m, 1.0 / width, 1.0 / height); wlr_matrix_scale(m, 1.0 / width, 1.0 / height);