e78252adab
Fix segfault in xwm_read_data_source
2018-03-25 18:18:26 -04:00
2910972b25
xwm.h: fix guard ifdef and remove wlr_ prefix from xwm_atoms_contains
2018-03-04 11:16:18 +01:00
d9a724c4a2
xcb errors: init errors context at start
...
`xcb_errors_context_new` is more than just a malloc, it does a few
xcb requests so we benefit from not generating a new context everytime
2018-03-03 17:06:30 +01:00
7d1870c6f1
move xwm.h out of include/wlr
...
xwm.h was meant to be private, so move it to include/xwayland/xwm.h
We had an ifdef WLR_HAS_XCB_ICCCM in xwayland.h which was easy to move
to xwm, it is not safe to use the WLR_HAS_* in the public headers.
I checked a few of our current users and none rely on xwm.h being
public as expected (rootston, sway, hsroots)
2018-03-03 17:03:21 +01:00
f481791669
xcb error: get unhandled events names
...
This provides more friendly debug messages for unhandled events,
for example:
[xwayland/xwm.c:1033] unhandled X11 event: FocusOut (10)
[xwayland/xwm.c:1033] unhandled X11 event: MappingNotify (34)
2018-03-03 16:27:29 +01:00
8026cd2a06
xcb error: always log sequence
2018-03-03 16:13:45 +01:00
6f9da97565
xcb errors: address declare-assign style
2018-03-03 12:00:32 +01:00
f8428d1063
xcb errors: optional dependency with improved messages
...
Now message can look like:
[xwayland/xwm.c:991] xcb error: op ChangeProperty (no minor), code Window (no extension), value 6291465
instead of this one when the lib is not available:
[xwayland/xwm.c:999] xcb error: op 18:0, code 3, sequence 103, value 6291465
The value in case of Window is the window id, so we can tell what
function applied on which window which is a good start.
The sequence ought to be able to tell us more precisely which
invocation it was, but we never log it when calling functions
so is useless in practice and no longer logged.
2018-03-03 11:46:04 +01:00
2a9ba5c8dc
xcb errors: log raw values
2018-03-03 11:43:23 +01:00
5ec06dcecd
xwm: fix call of xcb_change_window_attributes for old gcc versions
...
gcc 6.3.0 (at least) complains about &values:
expected ‘const uint32_t * {aka const unsigned int *}’ but argument
is of type ‘uint32_t (*)[1] {aka unsigned int (*)[1]}’
Reported by thorwil on irc
2018-03-01 21:13:00 +01:00
bb676013ed
add xwayland unmanaged tests to support dmenu
...
This adds `wlr_xwayland_surface_is_unamanged`, to allow compositors more
fine grained control over XWayland focus.
A surface that is unmanaged should not receive focus, while other
windows that are just override redirect may want it (dmenu).
The way unamanged is determined is taken from wlc.
2018-02-26 12:02:49 +01:00
b1e2718dd7
xwayland: fix some use-after-free in xwm
2018-02-23 10:20:53 +01:00
1d9be89e2d
Revert "ELF Visibility"
2018-02-19 18:01:27 -05:00
86269052eb
Explicitly export EFL symbols
2018-02-19 14:26:40 +13:00
8c1cc45c7d
Merge pull request #629 from emersion/safe-wl-resource-get-user-data
...
Wrap wl_resource_get_user_data into safer helper functions
2018-02-16 09:27:26 -05:00
168e26489a
Add missing dependencies
2018-02-14 18:42:39 +00:00
392d54a35d
Wrap wl_resource_get_user_data into safer helper functions
...
This ensures we're not incorrectly casting a resource.
Fixes #628
2018-02-13 23:48:46 +01:00
c2e1474010
Reformat all #include directives
2018-02-12 21:29:23 +01:00
36ead80cd1
Make wlr_signal_emit_safe private
2018-02-12 19:52:47 +01:00
5e58d46cc1
Add wlr_signal_emit_safe
2018-02-12 09:12:31 +01:00
59c53e8333
Merge remote-tracking branch 'upstream/master' into output-damage
2018-01-21 22:18:06 +01:00
f704c3d42b
rootston: fix damage tracking for fullscreen xwayland views
2018-01-21 22:08:38 +01:00
47eb478c35
style: add else keywords in xwm.c
2018-01-21 17:04:23 +01:00
dcc743047b
style: include brackets for if/while/for, even if it's a single statement
2018-01-21 16:28:21 +01:00
eeffe11337
surface: add wlr_surface new_subsurface and wlr_subsurface destroy events
2018-01-21 14:22:33 +01:00
65b28b3823
xwayland: render children window in fullscreen
2018-01-14 18:19:37 +01:00
38ed3b4245
seat: rename selection_source to selection_data_source, remove unused data_device
2017-12-30 09:58:04 +01:00
6ed1884c84
xwm_get_render_format: fix typo in error message
2017-12-29 21:23:55 +01:00
ec952931a1
wlr_xwayland: preserve end of struct on restart
...
This is more robust than trying to recopy a few fields.
Note: wlr_xwayland->events.ready now resets after each trigger, so one can
hook on it again and be called when restart is ready
2017-12-29 20:50:50 +01:00
a6fb4b007b
xwm_get_render_format: check NULL return value
2017-12-29 20:31:04 +01:00
41649a1f9a
xwm_selection_finish: set NULL seat for xwayland
...
While they could eventually be split appart, the current approach could lead to
double wl_list_remove() calls on selections which is incorrect
2017-12-29 20:30:49 +01:00
e0eafa0429
xwayland: listen to wlr_seat destroy signal
2017-12-29 19:00:08 +01:00
61b91a5721
xwayland restart: copy seat and events over
...
This is very ugly, there must be a better way to do that (not memset it?)
Meanwhile, this fixes rootston xwayland on restart
2017-12-29 17:33:11 +01:00
bb0d888f25
xwayland selection: further cleanup on Xwayland exit
...
This is necessary if our last primary/clipboard selection was on Xwayland,
and we try to paste to native wayland after Xwayland died
2017-12-29 16:30:59 +01:00
f8a346380c
xwayland xwm_get_render_format: free reply
2017-12-29 15:56:47 +01:00
dad9543c51
Xwayland: remove xwm from selection seat listeners on destroy
2017-12-29 15:56:26 +01:00
e5dd98c7f5
xwayland/selection: handle wl_array_add failure better
...
Just abort and deregister instead of trying to throw some input out,
which would have lead to inconsistent paste
2017-12-28 12:17:57 +01:00
3eb4fa15ee
ENOMEM checks: consistently check wl_array_add return
2017-12-28 09:48:35 +01:00
ff13849624
config: Avoid clash with other config-headers
2017-12-27 17:13:58 +01:00
a79dc7df51
Merge pull request #524 from acrisci/role-committed
...
[wip] Role committed
2017-12-27 13:02:49 +01:00
5c5f0611c4
xwayland: role committed
2017-12-27 06:50:21 -05:00
e809250171
Merge pull request #519 from emersion/xwayland-primary-selection
...
Implement xwayland primary selection sync
2017-12-27 06:23:04 -05:00
1c9b09ca92
Add logging to selection message handlers
2017-12-27 11:58:51 +01:00
b3072f81fe
Allow calling xwm_set_seat with a NULL seat
2017-12-27 11:49:25 +01:00
57a09c8ca4
config: Put all defines into config.h
2017-12-26 18:51:27 +01:00
998267e291
Fix primary selection not sent to xwayland when clipboard is empty
2017-12-26 12:20:01 +01:00
4a11609b76
Fix use-after-free when destroying selection sources
2017-12-25 18:18:26 +01:00
cdc21cdcff
Properly free selection sources
2017-12-25 16:23:17 +01:00
6dffaa7bb7
Implement xwayland primary selection sync
2017-12-25 16:10:16 +01:00
810c4b119b
Fix clipboard from xwayland to wayland
2017-12-15 09:42:42 +01:00
76dcb694c1
Send empty selection when clipboard is empty
2017-12-15 09:37:04 +01:00
5584f42c1e
Destroy xwm selection window on destroy
2017-12-15 00:05:05 +01:00
6b42bfad18
Merge branch 'master' into xwm-selection
2017-12-14 23:59:04 +01:00
b884025558
Deny access to clipboard if no xwayland window is focused
2017-12-14 23:57:44 +01:00
75ef7860bb
Merge branch 'master' into display-destroy
2017-12-14 20:29:30 +01:00
343efd0c20
Only reply to clipboard selection events
2017-12-14 16:44:30 +01:00
a4094c82c7
Support selection MIME types from wayland to xwayland
2017-12-14 16:24:12 +01:00
62a16a356d
Support selection MIME types from xwayland to wayland
2017-12-14 13:59:36 +01:00
6ef0219763
Merge branch 'master' into xwm-selection
2017-12-14 11:20:38 +01:00
ea4b871e16
xwm: user custom event handler
2017-12-13 17:54:19 -05:00
c67a5824b8
Merge branch 'master' into display-destroy
2017-12-11 16:14:03 +01:00
4da4048189
remove todo
2017-12-09 09:21:11 -05:00
a4bb0574c4
selection fixes
2017-12-08 09:46:50 -05:00
52cda5653b
Revert "xwm: only take clipboard if window is focused"
...
This reverts commit e3542d879d
2017-12-08 09:23:26 -05:00
35188834db
Merge branch 'master' into feature/xwm-selection
2017-12-08 09:22:44 -05:00
31bafc2461
xwm: use edges enum
2017-12-08 06:03:57 -05:00
e30b943fbd
Destroy xwayland client when possible
2017-12-08 10:58:36 +01:00
b06535718d
Do not destroy wl_client in wlr_xwayland_finish
2017-12-08 01:38:45 +01:00
18eb1eee3f
Listen to display destroy in xwayland, rename wlr_egl_free
2017-12-08 00:59:37 +01:00
86df909256
xwayland: remove xwayland param from xsurface methods
2017-12-03 17:30:57 -05:00
5d7eb438d9
Merge pull request #437 from emersion/fullscreen
...
Fullscreen support
2017-11-30 03:25:05 -05:00
e3542d879d
xwm: only take clipboard if window is focused
2017-11-22 14:58:36 -05:00
1ae944c071
Use SIGUSR2 for vt switching instead of SIGUSR1
...
Xwayland uses SIGUSR1 to signal readiness.
With direct(-freebsd) session and Xwayland, wlroots was confusing the
Xwayland readiness signal with a vt switch signal, freezing the desktop.
Same problem was found in Weston in 2014:
https://phabricator.freedesktop.org/T7080
2017-11-22 16:29:31 +03:00
fc17c74516
xwayland: clean up seat setting
2017-11-22 08:23:23 -05:00
b0683874e9
xwm: send selection data
2017-11-22 08:10:06 -05:00
71aa634ac5
Fix Xwayland second socket path on non-Linux systems
...
It was creating two sockets with the same path
2017-11-22 15:17:10 +03:00
ea6f77b484
xwm: get selection data
2017-11-21 18:25:21 -05:00
39e2ea8420
xwm: get selection targets
2017-11-21 18:09:25 -05:00
dcb168914e
Merge branch 'master' into fullscreen
2017-11-21 18:34:12 +01:00
1ada1b7f0b
xwm: x11 data source
2017-11-21 11:19:55 -05:00
c67cf2e9e4
xwm: handle selection stubs
2017-11-21 10:18:44 -05:00
1f976a0f25
xwm: xfixes selection notify
2017-11-21 09:25:05 -05:00
e786d17f63
Merge branch 'master' into feature/xwm-selection
2017-11-21 07:55:36 -05:00
151901123f
Merge branch 'master' into refactor-wlr-list
2017-11-20 21:15:58 +01:00
bc68f26960
Fix evince fullscreen under xwayland
2017-11-20 19:52:47 +01:00
444257b6b1
xwm: selection init
2017-11-20 08:51:40 -05:00
3880fb0a53
xwm: selection stubs
2017-11-20 07:42:09 -05:00
0672d9cb52
bug: properly send WM_STATE
2017-11-19 17:55:02 -05:00
016744ef4d
Refactor wlr_list inside wlroots
2017-11-19 00:17:40 +01:00
a317ecdab8
Run startup command after xwayland is ready
2017-11-12 16:01:48 -05:00
26dadacb71
Add wl_shell support for maximized views
2017-11-09 20:06:05 +01:00
758514fe5d
Fix xwayland _NET_WM_STATE handling
2017-11-09 11:21:55 +01:00
900fb326f7
Fixes segfault when no xcb_render_pictforminfo_t is available
2017-11-02 17:21:00 +01:00
bb76f52640
Fetch xcb_render_pictformat_t at startup
2017-11-02 16:59:57 +01:00
3f4ad47421
Use compositor theme for xwm cursor
2017-11-02 16:49:22 +01:00
ddd7b7711c
Load xwm cursor from theme
2017-11-02 15:52:02 +01:00
4254c28138
Free xwm cursor in xwm_destroy
2017-11-02 11:09:14 +01:00
bdaf66a292
Set xwayland root cursor
2017-11-02 00:03:55 +01:00
bf225a60d8
rootston: flush 'close' command on Xwayland
...
The close would otherwise wait for another xcb event to happen.
Flushing helps 'close' feel reactive.
2017-11-01 20:08:26 +01:00
ce72a687ce
xwm: cleanup send focus window logic
2017-10-29 10:40:16 -04:00
emersion
Dominique Martinet
Markus Ongyerth
Drew DeVault
Scott Anderson
Rodrigo Lourenço
Johannes Schramm
Björn Esser
Tony Crisci
Greg V