wlroots/include/backend/drm
Simon Ser cc8bc0db20 backend/drm: stop restoring CRTCs on exit
This is the cause of the spurious "drmHandleEvent failed" messages
at exit. restore_drm_outputs calls handle_drm_event in a loop without
checking whether the FD is readable, so drmHandleEvent ends up with a
short read (0 bytes) and returns an error.

The loop's goal is to wait for all queued page-flip events to complete,
to allow drmModeSetCrtc calls to succeed without EBUSY. The
drmModeSetCrtc calls are supposed to restore whatever KMS state we were
started with. But it's not clear from my PoV that restoring the KMS
state on exit is desirable.

KMS clients are supposed to save and restore the (full) KMS state on VT
switch, but not on exit. Leaving our KMS state on exit avoids unnecessary
modesets and allows flicker-free transitions between clients. See [1]
for more details, and note that with Pekka we've concluded that a new
flag to reset some KMS props to their default value on compositor
start-up is the best way forward. As a side note, Weston doesn't restore
the CRTC by does disable the cursor plane on exit (see
drm_output_deinit_planes, I still think disabling the cursor plane
shouldn't be necessary on exit).

Additionally, restore_drm_outputs only a subset of the KMS state.
Gamma and other atomic properties aren't accounted for. If the previous
KMS client had some outputs disabled, restore_drm_outputs would restore
a garbage mode.

[1]: https://blog.ffwll.ch/2016/01/vt-switching-with-atomic-modeset.html
2021-07-20 15:33:26 +02:00
..
cvt.h backend/drm: add support for custom modes 2019-10-27 10:46:47 -04:00
drm.h backend/drm: stop restoring CRTCs on exit 2021-07-20 15:33:26 +02:00
iface.h backend/drm: remove backend arg from wlr_drm_interface.crtc_commit 2021-07-09 15:31:19 -04:00
properties.h backend/drm: add support for the subconnector property 2021-01-17 12:42:25 +01:00
renderer.h output: take a wlr_buffer in set_cursor 2021-06-02 11:08:52 +02:00
util.h backend/drm: introduce wlr_drm_fb 2020-04-28 09:54:52 +02:00