blankie
/
wlroots
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
wlroots/include/xwayland/selection.h

91 lines
2.7 KiB
C
Raw Normal View History

xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
#ifndef XWAYLAND_SELECTION_H
#define XWAYLAND_SELECTION_H
#include <xcb/xfixes.h>
#define INCR_CHUNK_SIZE (64 * 1024)
#define XDND_VERSION 5
primary-selection: introduce wlr_primary_selection_source This is a common interface that can be used for all primary selection protocols, as discussed in [1]. A new function wlr_seat_set_primary_selection is added to set the primary selection for all protocols. The seat now owns again the source, and resets the selection to NULL when destroyed. [1]: https://github.com/swaywm/wlroots/issues/1367#issuecomment-442403454
2018-11-28 15:37:35 +00:00
struct wlr_primary_selection_source;
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
struct wlr_xwm_selection;
struct wlr_xwm_selection_transfer {
struct wlr_xwm_selection *selection;
bool incr;
bool flush_property_on_delete;
bool property_set;
struct wl_array source_data;
xwayland/selection: rename Wayland-facing data and helpers Previously, wlr_xwm_selection_transfer.source_fd meant: - the source of data in a Wayland -> X11 copy (good) - the destination of data in a X11 -> Wayland copy (confusing) This made reading through xwayland/selection/incoming.c difficult: in many places, "source" actually means "destination".
2021-01-25 02:09:53 +00:00
int wl_client_fd;
struct wl_event_source *event_source;
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
struct wl_list link;
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
// when sending to x11
xcb_selection_request_event_t request;
// when receiving from x11
int property_start;
xcb_get_property_reply_t *property_reply;
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
xcb_window_t incoming_window;
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
};
struct wlr_xwm_selection {
struct wlr_xwm *xwm;
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
xcb_atom_t atom;
xcb_window_t window;
xcb_window_t owner;
xcb_timestamp_t timestamp;
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
struct wl_list incoming;
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
struct wl_list outgoing;
};
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
struct wlr_xwm_selection_transfer *
xwm_selection_find_incoming_transfer_by_window(
struct wlr_xwm_selection *selection, xcb_window_t window);
xwayland/selection: rename Wayland-facing data and helpers Previously, wlr_xwm_selection_transfer.source_fd meant: - the source of data in a Wayland -> X11 copy (good) - the destination of data in a X11 -> Wayland copy (confusing) This made reading through xwayland/selection/incoming.c difficult: in many places, "source" actually means "destination".
2021-01-25 02:09:53 +00:00
void xwm_selection_transfer_remove_event_source(
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
struct wlr_xwm_selection_transfer *transfer);
xwayland/selection: rename Wayland-facing data and helpers Previously, wlr_xwm_selection_transfer.source_fd meant: - the source of data in a Wayland -> X11 copy (good) - the destination of data in a X11 -> Wayland copy (confusing) This made reading through xwayland/selection/incoming.c difficult: in many places, "source" actually means "destination".
2021-01-25 02:09:53 +00:00
void xwm_selection_transfer_close_wl_client_fd(
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
struct wlr_xwm_selection_transfer *transfer);
void xwm_selection_transfer_destroy_property_reply(
struct wlr_xwm_selection_transfer *transfer);
xwayland/selection: use one X11 window per incoming transfer This commit introduces logic for using a new X11 window for each incoming transfer, rather than having a global window for each selection source. This eliminates a whole class of bugs involving multiple concurrent incoming transfers. For now, we retain the outgoing transfer queue, and the selection source-specific windows to support it. Source-specific windows are no longer used in the incoming path, and will be removed in a future PR. Refs #1497.
2021-01-31 04:43:25 +00:00
void xwm_selection_transfer_init(struct wlr_xwm_selection_transfer *transfer,
struct wlr_xwm_selection *selection);
void xwm_selection_transfer_destroy(
struct wlr_xwm_selection_transfer *transfer);
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
xwayland/selection: destroy all selections on Xwayland restart Previously, Xwayland could restart, and we'd get events for transfers pointing to the previous (now freed) xwm instance. This led to use-after-free segfaults. Closes #2565.
2021-01-30 00:00:17 +00:00
void xwm_selection_transfer_destroy_outgoing(
struct wlr_xwm_selection_transfer *transfer);
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
xcb_atom_t xwm_mime_type_to_atom(struct wlr_xwm *xwm, char *mime_type);
char *xwm_mime_type_from_atom(struct wlr_xwm *xwm, xcb_atom_t atom);
struct wlr_xwm_selection *xwm_get_selection(struct wlr_xwm *xwm,
xcb_atom_t selection_atom);
void xwm_send_incr_chunk(struct wlr_xwm_selection_transfer *transfer);
void xwm_handle_selection_request(struct wlr_xwm *xwm,
xcb_selection_request_event_t *req);
xwm: end transfers when the requestor is destroyed This improves the failure cases when incremental transfers fail to complete successfully for one reason or another.
2020-07-03 02:25:25 +00:00
void xwm_handle_selection_destroy_notify(struct wlr_xwm *xwm,
xcb_destroy_notify_event_t *event);
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
void xwm_get_incr_chunk(struct wlr_xwm_selection_transfer *transfer);
void xwm_handle_selection_notify(struct wlr_xwm *xwm,
xcb_selection_notify_event_t *event);
int xwm_handle_xfixes_selection_notify(struct wlr_xwm *xwm,
xcb_xfixes_selection_notify_event_t *event);
Make sure we don't use others' prefixes
2018-04-25 22:24:58 +00:00
bool data_source_is_xwayland(struct wlr_data_source *wlr_source);
bool primary_selection_source_is_xwayland(
primary-selection: introduce wlr_primary_selection_source This is a common interface that can be used for all primary selection protocols, as discussed in [1]. A new function wlr_seat_set_primary_selection is added to set the primary selection for all protocols. The seat now owns again the source, and resets the selection to NULL when destroyed. [1]: https://github.com/swaywm/wlroots/issues/1367#issuecomment-442403454
2018-11-28 15:37:35 +00:00
struct wlr_primary_selection_source *wlr_source);
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
void xwm_seat_handle_start_drag(struct wlr_xwm *xwm, struct wlr_drag *drag);
xwayland/selection: make xwm_selection_init take a wlr_xwm_selection * This makes it consistent with xwm_selection_finish.
2021-01-31 17:27:54 +00:00
void xwm_selection_init(struct wlr_xwm_selection *selection,
struct wlr_xwm *xwm, xcb_atom_t atom);
xwayland/selection: make xwm_selection_finish take a wlr_xwm_selection * Previously it took a wlr_xwm *, which was a bit surprising in that it freed members of wlr_xwm *, not just its respective selections.
2021-01-30 04:47:03 +00:00
void xwm_selection_finish(struct wlr_xwm_selection *selection);
xwayland: refactor selection code
2018-04-03 16:12:57 +00:00
#endif