843621714f
surface: fix double wl_buffer.release events
...
Prior to this commit, we re-uploaded the buffer even if a new one
wasn't attached. After uploading, we send wl_buffer.release. So,
this sequence of requests resulted in a double release:
surface.attach(buffer, 0, 0)
surface.commit()
<- buffer.release()
surface.commit()
<- buffer.release()
2018-06-17 12:49:34 +01:00
fb118ac996
Merge pull request #1062 from emersion/wlr-buffer-comeback
...
Add back wlr_buffer
2018-06-16 13:43:14 -07:00
225aa815b0
buffer: fix wlr_texture leak on failed alloc
2018-06-16 19:01:13 +01:00
23707f6504
layer-shell: check whether the surface is mapped in layer_surface_destroy()
...
If the layer surface has been closed by the compositor, using
layer_surface_close(), then the unmap event is emitted. However, when
the layer surface is later destroyed by the client, the compositor used
to get a second unmap, which is fixed with this commit.
2018-06-16 17:29:53 +03:00
da114d5013
buffer: don't destroy DMA-BUF textures with wl_buffer
...
After some discussions on #wayland, it seems that as soon as you
hold a reference to a DMA-BUF (via EGLImage for instance), the
underlying memory won't get free'd. The client is allowed to
re-use the DMA-BUF and upload something else to it though.
2018-06-14 10:15:14 +01:00
d27eeaa14c
Revert "Merge pull request #1050 from emersion/wlr-buffer"
...
This reverts commit 5e4af4862e9a1f0e2d5f
2018-06-13 19:57:42 -04:00
0378d143d9
surface: remove wlr_surface.texture
...
The texture is managed by the surface's wlr_buffer now. In
particular, the buffer can destroy the texture early if it becomes
invalid.
2018-06-13 19:38:10 +01:00
38d415dd20
buffer: make wlr_buffer_ref return the buffer
2018-06-11 08:13:35 +01:00
e4933ab445
Introduce wlr_buffer
2018-06-08 20:06:13 +01:00
6f895081e1
Merge pull request #1043 from acrisci/drag-icon-unmap
...
drag-icon map and unmap fixes
2018-06-07 11:18:58 +01:00
211463ba87
Merge pull request #1045 from ammen99/master
...
xdg-shells: add a set_parent signal to toplevel surfaces
2018-06-06 21:38:32 +01:00
1a07bf95ae
Merge pull request #1044 from emersion/fix-box-intersection
...
box: fix wlr_box_intersection
2018-06-06 11:59:40 -04:00
a989104a6b
xdg-shells: add a set_parent signal to toplevel surfaces
2018-06-06 17:08:06 +03:00
ed89a24328
box: fix wlr_box_intersection
2018-06-06 08:47:04 +01:00
7c888a39c6
update drag position at the right times
2018-06-05 23:45:03 -04:00
319ebdf476
add back map event
2018-06-05 22:50:29 -04:00
1c75d4e54a
rename drag-icon map to unmap
2018-06-05 18:17:42 -04:00
c6821f3dd3
wlr_surface: insert subsurfaces in revert order
...
sibling surfaces were drawn in incorrect order (e.g. latest below).
This attempts to fix that by reverting the order of the list.
2018-06-05 21:02:42 +09:00
7206997e95
fix wlr_box_intersection and closest_point
2018-06-04 18:56:57 -04:00
a57d1baf57
Merge pull request #1033 from RyanDwyer/fix-xdg-popups
...
Fix mistakes in xdg_popup and xdg_popup_v6
2018-06-04 18:46:58 -04:00
344374fa14
Merge pull request #1039 from acrisci/positioner-invert-x-fix
...
add missing anchor case in positioner invert-x for xdg-shell
2018-06-04 22:27:26 +01:00
bcb660cb1d
add missing anchor case in positioner invert-x
2018-06-04 17:16:17 -04:00
78966417f4
Merge pull request #1031 from martinetd/multibind-seat
...
seat: allow clients to bind to seat multiple times
2018-06-04 16:44:22 +01:00
cf9b8c0a8c
wlr_surface_get_root_surface: walk up parent
...
This would dead-loop and never walk up if called on a subsurface
2018-06-05 00:17:58 +09:00
51b9883ea0
seat: allow clients to bind to seat multiple times
...
This lets clients bind to a seat multiple times by re-using the existing
wlr_seat_client whenever a duplicate request happens.
Previously, an independant wlr_seat_client would be created and only
events from one would be processed.
Fixes #1023 .
2018-06-04 22:31:36 +09:00
eb8b8acca6
wlr_linux_dmabuf: Fix printf conversion specifiers on armhf
...
The printf conversion specifiers in a call to wl_resource_post_error
do not specify the type correctly on armhf:
../types/wlr_linux_dmabuf.c: In function 'params_add':
../types/wlr_linux_dmabuf.c:104:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
"sent modifier %lu for plane %u, expected modifier %lu like other planes",
~~^
%llu
To fix this, we use standard printf conversion specifier macros from
inttypes.h.
2018-06-04 13:20:09 +00:00
516c864d46
Fix mistakes in xdg_popup and xdg_popup_v6
2018-06-04 22:00:40 +10:00
7b07b3f95d
Fix type in wlr_surface_get_extends
2018-06-01 16:36:04 +02:00
3994762ae0
Add wlr_surface_get_geometry
...
This function defaults and clips the xdg-surface geometry to the
bounding box of the surface + its subsurfaces, as specified by the
protocol spec.
2018-06-01 15:21:18 +02:00
6b7a55aa3d
Merge pull request #1020 from emersion/remove-check-dmabuf
...
render: remove wlr_renderer_check_import_dmabuf
2018-05-31 21:49:57 +01:00
21928cbe61
Merge branch 'master' into screencontent
2018-05-31 12:33:27 +01:00
d1cf9acbd5
cleanup: Use void for zero-parameter functions
...
Signed-off-by: Genki Sky <sky@genki.is>
2018-05-30 20:19:16 -04:00
f90b024ad0
linux-dmabuf: fix bound checks for stride and height
...
- Fix bound checking for offset + stride * height
- Make offset bound checking more consistent
- Reject zero strides
2018-05-30 19:46:24 +01:00
135721118a
render: remove wlr_renderer_check_import_dmabuf
...
It's possible to implement it outside the renderer, by creating a
texture and destroying it right away. This reduces the API surface
of the renderer.
2018-05-30 17:08:15 +01:00
41e53d1499
Merge pull request #1019 from emersion/virtual-keyboard-destroy
...
virtual-keyboard: fix wlr_virtual_keyboard_manager_v1_destroy
2018-05-30 13:51:34 +01:00
28020ff577
Only allow one modifier per DMA-BUF, split attributes struct in render/
2018-05-30 09:29:12 +01:00
f580112dca
virtual-keyboard: fix wlr_virtual_keyboard_manager_v1_destroy
2018-05-30 09:25:46 +01:00
87fe9f3466
Merge pull request #1014 from RyanDwyer/fix-wlr-box-contains-point
...
Fix wlr_box_contains_point comparison
2018-05-29 19:03:29 +01:00
2681352e04
export-dmabuf: permanently fail if backend doesn't implement export_dmabuf
2018-05-29 18:47:19 +01:00
a16ad4327a
Update protocol
2018-05-29 18:47:19 +01:00
65198b0aab
export-dmabuf: assert number of planes
2018-05-29 18:47:19 +01:00
2432c41a49
export-dmabuf: correctly send the number of planes per layer
2018-05-29 18:47:18 +01:00
3f9796112e
export-dmabuf: fix tv_sec_hi
2018-05-29 18:47:18 +01:00
00e108f2fc
export-dmabuf: correctly finish wlr_linux_dmabuf_attribs
2018-05-29 18:47:18 +01:00
1377e551ef
Update wlr-export-dmabuf protocol
2018-05-29 18:47:18 +01:00
e26f4dff98
export-dmabuf: wait for the frame to be ready, send timestamp
2018-05-29 18:47:17 +01:00
36bd4795d4
export-dmabuf: add basic and incomplete implementation
2018-05-29 18:47:17 +01:00
9e26808c28
output, backend/drm: add wlr_output_export_dmabuf
2018-05-29 18:45:45 +01:00
e1f56538a8
Merge pull request #999 from dcz-purism/virtual-keyboard
...
Support virtual keyboard protocol
2018-05-29 18:22:44 +01:00
f8a831859f
Fix wlr_box_contains_point comparison
2018-05-29 23:05:01 +10:00
5334ee8bfd
virtual-keyboard: add support for the virtual-keyboard-v1 protocol
2018-05-28 10:05:55 +02:00
47f097e09b
xdg-shell: add wlr_xdg_toplevel_set_tiled
2018-05-27 13:38:06 +01:00
da504f9253
surface: remove wl_resource_post_event
2018-05-26 19:43:55 +01:00
e849a68e6e
output: correctly clear screen when fullscreened
2018-05-20 13:44:18 +01:00
98088e78df
Merge pull request #977 from emersion/split-xdg-shell
...
Split xdg-shell into multiple files
2018-05-17 08:14:34 -04:00
c74f5b1138
xdg-output: bump output manager version to 2
2018-05-17 09:30:10 +01:00
63fd2203fe
Add support for version 2 of the xdg-output protocol
2018-05-17 08:42:59 +01:00
dbba1311b7
output: fix lingering hardware cursors
2018-05-15 18:13:26 +01:00
3036507463
xdg-shell: split into multiple files
2018-05-14 22:28:45 +01:00
c7480d5084
xdg-shell-v6: rename shared private functions to prevent conflicts with xdg-shell stable
2018-05-14 19:16:46 +01:00
facc5aa359
xdg-shell-v6: split into separate files
2018-05-13 22:32:03 +01:00
cc12d03545
xdg-shell: fix positioner
...
The anchor and gravity bitfields in xdg-shell-unstable-v6 have
been changed to a plain enum whose values cannot be used as a
bitfield in xdg-shell. While it makes input validation easier, it
also makes positioner operations a pain in the ass.
2018-05-13 09:07:25 +01:00
b28f06eca0
Don't use unsafe casts in wlr_xdg_popup_get_toplevel_coords
2018-05-12 22:53:11 +01:00
7a952dfa2d
xdg-output: fix logical_size
...
It should be the size of the output in layout coordinates. Prior to
this commit we were not applying the output transform to the size.
2018-05-12 16:25:52 +01:00
db84379242
Send axis source event
2018-05-12 13:53:21 +01:00
0b58579564
Add support for discrete axis values
2018-05-12 13:34:58 +01:00
cf5013416d
xdg-output: redesign resource destroy
2018-05-11 22:30:26 +01:00
13098a18ea
Fix hardware cursors scale & transform
2018-05-09 19:58:18 +01:00
8931452e1d
add wlr_layer_surface_surface_at
...
Adds wlr_layer_surface_surface_at, this is consistent with the other
shell implementations, and simplifies handling in compositors.
2018-05-08 16:03:10 +02:00
5087199d5d
output-damage: limit the number of damaged rectangles
2018-05-05 14:28:55 +01:00
caf9f9022c
Merge pull request #936 from emersion/full-hardware-cursors
...
output: always use hardware cursors if available
2018-05-04 19:00:45 +01:00
2959fcce1a
Merge pull request #951 from chebykinn/fix-maybe-uninitialized
...
Fix gcc maybe-uninitialized in wlr_cursor apply_output_transform
2018-05-04 16:56:53 +01:00
57d03a3eda
Merge pull request #931 from emersion/redesign-resource-destroy
...
Redesign resource destruction
2018-05-04 11:48:41 -04:00
cec7cd2b39
Fix gcc maybe-uninitialized in wlr_cursor apply_output_transform
2018-05-04 18:41:51 +03:00
d136026a2c
seat: implement inert seat resources
2018-05-03 22:03:44 +01:00
6305e6327f
Fix typos in comments and strings
2018-05-03 21:59:43 +01:00
5d37b14116
data-device: make sure resources are correctly destroyed
2018-05-03 20:22:51 +01:00
7843a48432
output: simplify and update code style
2018-05-03 18:46:17 +01:00
ff4708d406
linux-dmabuf: correctly destroy resources
2018-05-03 18:45:30 +01:00
6d569def6d
compositor, surface: correctly destroy resources
2018-05-03 18:45:30 +01:00
2964248f42
Merge pull request #935 from agx/cursor-output-transform
...
wlr_cursor: transform absolute coordinates
2018-05-03 07:29:32 -04:00
2cff6dbd63
seat: split into multiple files
2018-05-03 10:30:47 +01:00
4b5b02057c
Merge pull request #937 from emersion/reorder-data-device
...
data-device: split into multiple files
2018-05-03 10:23:08 +01:00
4efae8c177
wlr_cursor: transform absolute coordinates
...
Honor output rotation when processing absolute coordinates. This fixes
touch events on rotated outputs.
Fixes #928
2018-05-03 11:09:14 +02:00
1e563e7ecf
data-device: split into multiple files
2018-05-02 18:04:10 +01:00
6b3eac37f1
output: assert move_cursor if set_cursor is available
2018-05-02 15:04:35 +01:00
8f5045c871
Silently ignore touch_{motion,up} for unknown ids
2018-05-02 08:59:27 -04:00
225d182765
output: always use hardware cursors if available
...
This changes the `wlr_output_impl.set_cursor` function to take a
`wlr_texture` instead of a byte buffer. This simplifies the
DRM and Wayland backends since they were creating textures from
the byte buffer anyway.
With this commit, performance should be improved when moving the
cursor since outputs don't need to be re-rendered anymore.
2018-05-01 21:38:04 +01:00
2551ef8871
input-device: add output_name field, populate it from libinput
2018-04-29 14:30:09 +01:00
a0f4903063
Merge pull request #926 from emersion/fix-x11-backend-memory-leaks
...
Fix some backend memory leaks
2018-04-29 08:00:59 -04:00
f8e0a03451
backend/x11: correctly destroy input devices
2018-04-28 12:55:36 +01:00
79da4c175e
backend/headless: remove useless destructor
2018-04-28 12:48:05 +01:00
6e7c0b57f6
cursor: use NAN for unspecified axes, refactor absolute warping code
2018-04-28 09:24:38 +01:00
126f12e428
xdg-shell: fix invalid xdg-positioner cast
2018-04-26 18:53:59 +01:00
43012f3740
compositor: redesign how resources are managed
...
All public resource creators now take a new ID for the resource
and an optional list where the resource link is added. When the
resource is destroyed it is its own responsibility to remove
itself from the list. This removes the need for the caller to add
a destroy listener.
This commit fixes a few segfaults with resources not removed from
the list when destroyed.
2018-04-26 17:51:06 +01:00
979b1b22d5
Merge pull request #914 from emersion/misc-segfault-fixes
...
Misc segfault fixes
2018-04-26 17:37:27 +02:00
874909dca6
xdg-shell: fix invalid wlr_xdg_positioner alloc
2018-04-26 15:59:23 +01:00
fcb7ad925d
layer-shell: fix use-after-free when client requests an invalid layer
2018-04-26 15:58:41 +01:00
93ebd33aa8
Merge pull request #890 from agx/layer-shell-empty-output-crash
...
layer-shell: Fix crash when cursor is intially outside any output
2018-04-26 14:31:35 +02:00
d81f0170a3
layer-shell: Don't crash when the compositor didn't find a suitable output
...
In that case it must have closed the surface.
2018-04-26 14:08:30 +02:00
fecb971518
Merge pull request #902 from emersion/various-memory-leaks
...
Various memory leaks
2018-04-26 11:34:49 +02:00
449f06556a
Destroy wlr_surface with wlr_renderer
2018-04-26 00:11:36 +01:00
d47713ac0f
compositor: destroy subsurface resources with wlr_subcompositor
2018-04-25 23:53:44 +01:00
89a9c96fab
compositor: make wlr_compositor_destroy destroy resources
2018-04-25 23:53:44 +01:00
625a7a48dc
Don't use the wlr_ prefix for static functions
2018-04-25 23:51:00 +01:00
b0d99f5c67
Remove wlr_ prefix from local symbols
2018-04-25 23:00:46 +01:00
8e2f3056f8
layer-shell: fix small memory leak
2018-04-24 22:40:48 +01:00
bc0bfde5ee
cursor: allow to call wlr_cursor_wrap_absolute with zero
2018-04-24 19:46:29 +01:00
38064f1d18
Fix protocol error when a client destroys and re-creates a subsurface
2018-04-23 21:50:15 +01:00
941f88ce23
Fix popup positioning & double popups
2018-04-23 11:24:06 +02:00
52baf3dd8a
Move get_geometry call back to xdg-shell
2018-04-23 11:24:06 +02:00
0a0627f5d0
Finish forward-porting @acrisci's positioner work
2018-04-23 11:24:06 +02:00
2e3d901ac5
Forward-port xdg-shell-v6 positioner improvements
2018-04-23 11:24:06 +02:00
278aa84619
Basic layer popup rendering
2018-04-23 11:24:06 +02:00
d3cdb00208
Add (shitty) support for popups to layer example
2018-04-23 11:24:06 +02:00
6b7b64ec1e
Generalize xdg-shell popups and add to layer-shell
2018-04-23 11:22:23 +02:00
625bc7b8b3
assert(surface->output); after new_surface emit
2018-04-23 10:45:48 +02:00
177b548b15
Update layer shell with optional wl_output
2018-04-22 18:57:45 +02:00
3bce5dfc9f
Fix segfaults in wlr_surface_is_*
2018-04-21 19:04:48 +01:00
bfcd3f3707
Add wlr_subcompositor
2018-04-21 19:02:39 +01:00
fa84b267e0
Remove wlr_surface::subsurface
2018-04-21 18:40:25 +01:00
c8ccb1bef3
reorder xkb state handling in wlr_keyboard
...
wlr_keyboard manages the xkb-common state of the compositor.
It used to update the state, update the modifiers, then notify the
compositor.
When [Shift_L] was pressed and released, this resulted in an event chain:
Modifiers: Shift
Key: Shift_L (Pressed)
Modifiers:
Key: Shift_L (Release)
The xkb-docs state that the state should be updated *after* the key was
handled [1], to prevent the new state from influencing the actual key
generated.
To achieve this, the event to the compositor is emitted, *before*
wlroots handles the xkb and internal keyboard state.
With this patch applied, the emitted events ill be:
Modifiers:
Key: Shift_L (Pressed)
Modifiers: Shift
Key: Shift_L (Release)
[1] https://xkbcommon.org/doc/current/group__state.html#gac554aa20743a621692c1a744a05e06ce
2018-04-18 11:54:59 +02:00
94fa6c88f4
output: don't emit the mode event if it hasn't changed
...
This also fixes #535 .
2018-04-18 00:15:25 +01:00
1b802d9251
Make wlr_renderer_scissor take normal coords instead of upside-down ones
2018-04-12 19:38:33 -04:00
8f4039d799
Merge pull request #861 from emersion/fix-output-transform-compose
...
Fix wlr_output_transform_compose
2018-04-12 19:27:57 -04:00
31c8bdc277
Fix wlr_output_transform_compose
2018-04-12 19:05:05 -04:00
fa0be972bb
Fix wlr_xdg_surface_surface_at for popups
2018-04-12 17:17:32 -04:00
bef5c1fd56
Merge pull request #850 from emersion/remove-backend-egl
...
backend: remove wlr_backend_get_egl
2018-04-08 11:21:21 -04:00
d2ebbd103c
backend: remove wlr_backend_get_egl
2018-04-08 11:00:56 -04:00
bf68854a38
Fix destruction of popups without grabs
...
Fixes #846
2018-04-07 12:21:21 -04:00
ae4cef9e41
Merge pull request #825 from emersion/surface-iterators
...
Add surface iterators
2018-04-05 23:06:29 -04:00
ec0ce8ae1c
Fix sending updates to xdg-output resources
...
Fixes #836
2018-04-05 18:22:48 -04:00
6710de9878
Merge branch 'master' into xwayland-dnd
2018-04-05 15:04:49 -04:00
4a9a9eae9a
Add surface iterators
2018-04-05 14:18:17 -04:00
19b576734e
Merge pull request #834 from emersion/surface-is-subsurface
...
Add wlr_surface_is_subsurface and wlr_subsurface_from_surface
2018-04-05 14:16:45 -04:00
aced024819
Add wlr_surface_is_subsurface and wlr_subsurface_from_surface
2018-04-05 14:00:53 -04:00
abfe7923c4
Add wlr_xdg_output_manager
2018-04-05 12:40:30 -04:00
3ea425d4e2
Fix xdg-shell popups, add wlr_xdg_surface_surface_at
2018-04-04 17:45:24 -04:00
c9d21106b4
Add wlr_xdg_surface_v6_surface_at and wlr_wl_shell_surface_surface_at
2018-04-04 17:42:16 -04:00
1a8b24bdd2
rootston: fix view_at
2018-04-04 17:16:35 -04:00
d16127b3cb
Fix wlr_surface_subsurface_at, change it to be wlr_surface_surface_at
2018-04-04 16:48:23 -04:00
36e94b2a8e
Actually fix input inhibitor destructor
2018-04-03 16:58:06 -04:00
1fa3ca3152
Revert "Add destructor to inhibitor"
...
This breaks shit
This reverts commit 657d2c9a69
2018-04-03 16:41:01 -04:00
657d2c9a69
Add destructor to inhibitor
2018-04-03 16:01:30 -04:00
ef4e833f13
Add wlr_input_inhibitor
2018-04-03 14:06:52 -04:00
58ac05c276
Merge branch 'master' into xwayland-dnd
2018-04-03 10:38:46 -04:00
333ab59902
Add wlr_surface_is_*_surface
...
And wlr_*_surface_from_wlr_surface
2018-04-02 20:42:02 -04:00
8836b4f024
Merge branch 'master' into xwayland-dnd
2018-04-02 15:57:04 -04:00
5a47da1ea6
annotate wlr-output-layout coord variables
2018-04-01 00:17:27 -04:00
1778818a50
Don't destroying all layer surfaces on client d/c
2018-03-31 00:22:09 -04:00
emersion
Drew DeVault
Ilia Bozhinov
Tony Crisci
Dominique Martinet
Bob Ham
Ryan Dwyer
Markus Ongyerth
Genki Sky
Dorota Czaplejewicz
Ivan Chebykin
morganamilo
Guido Günther